Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in SearchBuffer.

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1215 matching lines @@
         DCHECK(frame().document());
         ApplyStyleCommand::create(*frame().document(), blockStyle, editingAction)->apply();
     }
 
     // Set the remaining style as the typing style.
     frame().selection().setTypingStyle(typingStyle);
 }
 
 bool Editor::findString(const String& target, FindOptions options)
 {
+    // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+    // see http://crbug.com/590369 for more details.
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();

[dglazkov, 2016/07/13 22:40:11]

This can go up one more, to EditorCommand and LocalDOMWindow.

+
     VisibleSelection selection = frame().selection().selection();
 
     // TODO(yosin) We should make |findRangeOfString()| to return
     // |EphemeralRange| rather than|Range| object.
     Range* resultRange = findRangeOfString(target, EphemeralRange(selection.start(), selection.end()), static_cast<FindOptions>(options | FindAPICall));
 
     if (!resultRange)
         return false;
 
     frame().selection().setSelection(VisibleSelection(EphemeralRange(resultRange)));
     frame().selection().revealSelection();
     return true;
 }
 
 Range* Editor::findStringAndScrollToVisible(const String& target, Range* previousMatch, FindOptions options)
 {
+    // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+    // see http://crbug.com/590369 for more details.
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();

[dglazkov, 2016/07/13 22:40:10]

This can go up one more as well, to WebLocalFrameImpl::find. Actually, that
method needs to be re-considered. The division of responsibilities is pretty
arbitrary.

+
     Range* nextMatch = findRangeOfString(target, EphemeralRangeInFlatTree(previousMatch), options);
     if (!nextMatch)
         return nullptr;
 
     Node* firstNode = nextMatch->firstNode();
     firstNode->layoutObject()->scrollRectToVisible(LayoutRect(nextMatch->boundingBox()),
         ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded, UserScroll);
     firstNode->document().setSequentialFocusNavigationStartingPoint(firstNode);
 
     return nextMatch;
@@ skipping 161 matching lines @@
 
 DEFINE_TRACE(Editor)
 {
     visitor->trace(m_frame);
     visitor->trace(m_lastEditCommand);
     visitor->trace(m_undoStack);
     visitor->trace(m_mark);
 }
 
 } // namespace blink