Issue 214463007: Merge 253627 "Properly handle failure modes in the wildcard logi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214463007: Merge 253627 "Properly handle failure modes in the wildcard logi..." (Closed)

Created:
6 years, 9 months ago by Mattias Nissler (ping if slow)

Modified:
6 years, 9 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

Merge 253627 "Properly handle failure modes in the wildcard logi..." > Properly handle failure modes in the wildcard login check. > > In the case of network failure for the user info fetch, the failing > check will be treated as a negative reply, which is incorrect for the > post-login checks. > > BUG=chromium:347081 > > Review URL: https://codereview.chromium.org/181363002 TBR=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259993

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -12 lines)			Patch
M	chrome/browser/chromeos/login/login_performer.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_performer.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/wildcard_login_checker.h	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/wildcard_login_checker.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Mattias Nissler (ping if slow)

6 years, 9 months ago (2014-03-27 21:24:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r259993 (tree was closed).