chrome/browser/chromeos/policy/wildcard_login_checker.h - Issue 214463007: Merge 253627 "Properly handle failure modes in the wildcard logi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/wildcard_login_checker.h

Issue 214463007: Merge 253627 "Properly handle failure modes in the wildcard logi..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1847/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc ('k') | chrome/browser/chromeos/policy/wildcard_login_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/wildcard_login_checker.h

===================================================================

--- chrome/browser/chromeos/policy/wildcard_login_checker.h (revision 259991)

+++ chrome/browser/chromeos/policy/wildcard_login_checker.h (working copy)

@@ -25,8 +25,15 @@

// reports the result via a callback.

class WildcardLoginChecker : public UserInfoFetcher::Delegate {

public:

- typedef base::Callback<void(bool)> StatusCallback;

+ // Indicates result of the wildcard login check.

+ enum Result {

+ RESULT_ALLOWED, // Wildcard check succeeded, login allowed.

+ RESULT_BLOCKED, // Check completed, but user should be blocked.

+ RESULT_FAILED, // Failure due to network errors etc.

+ };

+ typedef base::Callback<void(Result)> StatusCallback;

WildcardLoginChecker();

virtual ~WildcardLoginChecker();

@@ -53,7 +60,7 @@

void StartUserInfoFetcher(const std::string& access_token);

// Handles the response of the check and calls ReportResult().

- void OnCheckCompleted(bool result);

+ void OnCheckCompleted(Result result);

StatusCallback callback_;