Fix invalidating the text track indexes after append or remove text track from the list

Fix invalidating the text track indexes after append or remove text track from the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=

Committed: https://crrev.com/50a0e9966263d1a870c8fd1c2baf726b1729c54c
Cr-Commit-Position: refs/heads/master@{#405709}

[mfiglarowicz, 2016-07-12 07:04:07]

Description was changed from

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=
==========

to

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=
==========

[mfiglarowicz, 2016-07-12 07:04:07]

mfiglarowicz@opera.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[foolip, 2016-07-12 07:39:28]

I assume that this is observable in some way, can you try writing a test?

[mfiglarowicz, 2016-07-13 05:25:53]

I've added unit tests for this issue

[foolip, 2016-07-13 11:41:25]

lgtm % nits

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp (right):

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:2: * Copyright
(C) 2016, Opera Software ASA. All rights reserved.
For new files please use the short copyright header, search for "The Chromium
Authors" to find an example.

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:37:
TEST(TextTrackListTest, indexes_validity)
I'm not certain, but I think the names should be CamelCase as well, so
InvalidateTrackIndexes?

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:48: EXPECT_EQ(0,
textTracks[0]->trackIndex());
Maybe EXPECT_EQ(4, list->length()) here and EXPECT_EQ(3, list->length()) after
the removal?

[mfiglarowicz, 2016-07-14 07:04:56]

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp (right):

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:2: * Copyright
(C) 2016, Opera Software ASA. All rights reserved.
On 2016/07/13 11:41:25, foolip (OOO until July 18) wrote:
> For new files please use the short copyright header, search for "The Chromium
> Authors" to find an example.

Done.

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:37:
TEST(TextTrackListTest, indexes_validity)
On 2016/07/13 11:41:25, foolip (OOO until July 18) wrote:
> I'm not certain, but I think the names should be CamelCase as well, so
> InvalidateTrackIndexes?

Done.

https://codereview.chromium.org/2144543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp:48: EXPECT_EQ(0,
textTracks[0]->trackIndex());
On 2016/07/13 11:41:24, foolip (OOO until July 18) wrote:
> Maybe EXPECT_EQ(4, list->length()) here and EXPECT_EQ(3, list->length()) after
> the removal?

Done.

[foolip, 2016-07-14 09:57:25]

After a "lgtm % nits" it's OK to send to CQ yourself after addressing the
issues, but I'll check it for you now.

[foolip, 2016-07-14 09:57:30]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:17:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mfiglarowicz, 2016-07-15 06:09:20]

The CQ bit was checked by mfiglarowicz@opera.com

[commit-bot: I haz the power, 2016-07-15 06:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 06:39:51]

Description was changed from

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=
==========

to

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=
==========

[commit-bot: I haz the power, 2016-07-15 06:39:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-15 06:41:30]

Description was changed from

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=
==========

to

==========
Fix invalidating the text track indexes after append or remove text track from
the list

There was a trivial bug in 'for' loop which iterates through the array
indexes but always uses the initialisation value of the iterator instead of
real value of the iterator.

BUG=

Committed: https://crrev.com/50a0e9966263d1a870c8fd1c2baf726b1729c54c
Cr-Commit-Position: refs/heads/master@{#405709}
==========

[commit-bot: I haz the power, 2016-07-15 06:41:31]

Patchset 3 (id:??) landed as
https://crrev.com/50a0e9966263d1a870c8fd1c2baf726b1729c54c
Cr-Commit-Position: refs/heads/master@{#405709}