third_party/WebKit/Source/core/html/track/TextTrackList.cpp - Issue 2144543002: Fix invalidating the text track indexes after append or remove text track from the list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackList.cpp

Issue 2144543002: Fix invalidating the text track indexes after append or remove text track from the list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: All with unit tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/track/TextTrackList.cpp

diff --git a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

index 02dc1e260d9b9b56c429aa193642b1ef3a84075b..52eb5522dc5eae210b09e866bf796fc9fa28d821 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

+++ b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

@@ -167,7 +167,7 @@ void TextTrackList::invalidateTrackIndexesAfterTrack(TextTrack* track)

return;

for (size_t i = index; i < tracks->size(); ++i)

- tracks->at(index)->invalidateTrackIndex();

+ tracks->at(i)->invalidateTrackIndex();

}

void TextTrackList::append(TextTrack* track)

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/html/track/TextTrackListTest.cpp » ('j') | no next file with comments »