Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214453003: [DevTools] Don't handle shortcuts while dialog is open. (Closed)

Created:
6 years, 9 months ago by dgozman
Modified:
6 years, 9 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Don't handle shortcuts while dialog is open. BUG=356616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/devtools/front_end/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/InspectorView.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/Main.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
dgozman
Could you please take a look? This will be merged to M34.
6 years, 9 months ago (2014-03-27 11:18:15 UTC) #1
apavlov
lgtm
6 years, 9 months ago (2014-03-27 12:07:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/214453003/1
6 years, 9 months ago (2014-03-27 12:07:25 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 13:13:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 13:13:43 UTC) #5
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-27 15:14:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/214453003/1
6 years, 9 months ago (2014-03-27 15:15:08 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:34:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 15:34:26 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-27 15:38:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/214453003/1
6 years, 9 months ago (2014-03-27 15:38:56 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:47:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 15:47:00 UTC) #13
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-27 20:14:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/214453003/1
6 years, 9 months ago (2014-03-27 20:14:14 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:27:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 21:27:50 UTC) #17
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-28 07:14:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/214453003/1
6 years, 9 months ago (2014-03-28 07:14:37 UTC) #19
commit-bot: I haz the power
Change committed as 170294
6 years, 9 months ago (2014-03-28 08:15:54 UTC) #20
dgozman
6 years, 8 months ago (2014-03-31 10:11:22 UTC) #21
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/219013004/ by dgozman@chromium.org.

The reason for reverting is: We should still intercept browser shortcuts, even
with dialog open..

Powered by Google App Engine
This is Rietveld 408576698