Source/devtools/front_end/InspectorView.js - Issue 214453003: [DevTools] Don't handle shortcuts while dialog is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/InspectorView.js

Issue 214453003: [DevTools] Don't handle shortcuts while dialog is open. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/InspectorView.js

diff --git a/Source/devtools/front_end/InspectorView.js b/Source/devtools/front_end/InspectorView.js

index 4e55123d16531acc6d061209c5cea9dd959d5341..af6fd7b1b7a7aebf0065e2474e95c6f2877bfb43 100644

--- a/Source/devtools/front_end/InspectorView.js

+++ b/Source/devtools/front_end/InspectorView.js

@@ -293,6 +293,8 @@ WebInspector.InspectorView.prototype = {

{

if (!WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event))

return;

+ if (WebInspector.Dialog.currentInstance())

+ return;

var keyboardEvent = /** @type {!KeyboardEvent} */ (event);

// Ctrl/Cmd + 1-9 should show corresponding panel.

« no previous file with comments | « Source/devtools/front_end/Dialog.js ('k') | Source/devtools/front_end/Main.js » ('j') | no next file with comments »