Move AccessibilityDelegate ownership to ash::WmShell

Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org

Committed: https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434
Cr-Commit-Position: refs/heads/master@{#405810}

[James Cook, 2016-07-14 23:22:40]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:23:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-14 23:30:25]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:31:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-14 23:31:45]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-14 23:31:46]

msw, please take a look.

sadrul, just FYI, I moved AccessibilityDelegateMus into its own file.

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:54: media_delegate_.reset();
Not strictly necessary, but a little clearer I think.

[commit-bot: I haz the power, 2016-07-15 00:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:05:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-07-15 15:33:14]

lgtm with Shutdown comment and nit.

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:54: media_delegate_.reset();
On 2016/07/14 23:31:46, James Cook wrote:
> Not strictly necessary, but a little clearer I think.

I'd be wary of adding explicit destruction if none is needed. Shell has plenty
of relative lifetime (ctor/dtor ordering) issues, and this may imply that these
members need to be destroyed before the dtor or in some specific order. WDYT?

Maybe copy the comment from shell.cc if it applies to |accessibility_delegate_|:
  // Depends on |focus_client_|, so must be destroyed before.

https://codereview.chromium.org/2154523002/diff/20001/ash/mus/accessibility_d...
File ash/mus/accessibility_delegate_mus.cc (right):

https://codereview.chromium.org/2154523002/diff/20001/ash/mus/accessibility_d...
ash/mus/accessibility_delegate_mus.cc:10: class Connector;
nit: remove

[James Cook, 2016-07-15 17:03:06]

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2154523002/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:54: media_delegate_.reset();
On 2016/07/15 15:33:14, msw wrote:
> On 2016/07/14 23:31:46, James Cook wrote:
> > Not strictly necessary, but a little clearer I think.
> 
> I'd be wary of adding explicit destruction if none is needed. Shell has plenty
> of relative lifetime (ctor/dtor ordering) issues, and this may imply that
these
> members need to be destroyed before the dtor or in some specific order. WDYT?
> 
> Maybe copy the comment from shell.cc if it applies to
|accessibility_delegate_|:
>   // Depends on |focus_client_|, so must be destroyed before.

Done. Removed media_delegate_.reset(). Added a comment that
accessibility_delegate_ accesses WmShell in its destructor, which is the actual
problem.

https://codereview.chromium.org/2154523002/diff/20001/ash/mus/accessibility_d...
File ash/mus/accessibility_delegate_mus.cc (right):

https://codereview.chromium.org/2154523002/diff/20001/ash/mus/accessibility_d...
ash/mus/accessibility_delegate_mus.cc:10: class Connector;
On 2016/07/15 15:33:14, msw wrote:
> nit: remove

Done.

[James Cook, 2016-07-15 17:03:42]

Description was changed from

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
==========

to

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org
==========

[James Cook, 2016-07-15 17:03:42]

jamescook@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[James Cook, 2016-07-15 17:04:05]

TBR dmazzoni for mechanical rename touching
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc

[James Cook, 2016-07-15 17:04:11]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-15 17:04:12]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2154523002/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2016-07-15 17:04:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 18:05:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-07-15 18:19:05]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-15 18:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2154523002/#ps80001
(title: "fix mash_unittests")

[commit-bot: I haz the power, 2016-07-15 18:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:13:46]

Description was changed from

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org
==========

to

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org
==========

[commit-bot: I haz the power, 2016-07-15 19:13:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-15 19:14:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 19:17:17]

Description was changed from

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org
==========

to

==========
Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org

Committed: https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434
Cr-Commit-Position: refs/heads/master@{#405810}
==========

[commit-bot: I haz the power, 2016-07-15 19:17:18]

Patchset 5 (id:??) landed as
https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434
Cr-Commit-Position: refs/heads/master@{#405810}