Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2144353002:
Fix incorrect rendering of background color in out-of-process iframes. (Closed)
|
Created:
4 years, 5 months ago by lfg Modified:
4 years, 5 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix incorrect rendering of background color in out-of-process iframes.
BUG=619197
Committed: https://crrev.com/04c6bd6016500a2396142e07d09c582745350827
Cr-Commit-Position: refs/heads/master@{#406591}
Patch Set 1 #Patch Set 2 : add TODO #Messages
Total messages: 23 (15 generated)
The CQ bit was checked by lfg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lfg@chromium.org changed reviewers: + jbauman@chromium.org
PTAL.
Description was changed from ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 ========== to ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm It's a pity these need to always be marked as non-opaque, as that can be less efficient when drawing.
lfg@chromium.org changed reviewers: + piman@chromium.org
+piman for content/ owners review.
LGTM, but as jbauman said, it's much less efficient - can we add a TODO/file a bug to propagate the opaqueness information?
On 2016/07/19 20:25:46, piman wrote: > LGTM, but as jbauman said, it's much less efficient - can we add a TODO/file a > bug to propagate the opaqueness information? I'll file a bug, but I'm not sure if there are the security implications about leaking the information of the background of a cross-origin iframe.
The CQ bit was checked by lfg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lfg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2144353002/#ps20001 (title: "add TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 ========== to ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 ========== to ========== Fix incorrect rendering of background color in out-of-process iframes. BUG=619197 Committed: https://crrev.com/04c6bd6016500a2396142e07d09c582745350827 Cr-Commit-Position: refs/heads/master@{#406591} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/04c6bd6016500a2396142e07d09c582745350827 Cr-Commit-Position: refs/heads/master@{#406591} |
