Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: content/renderer/child_frame_compositing_helper.cc

Issue 2144353002: Fix incorrect rendering of background color in out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/child_frame_compositing_helper.cc
diff --git a/content/renderer/child_frame_compositing_helper.cc b/content/renderer/child_frame_compositing_helper.cc
index 80e0b67f86a6b13544304dd5e255da8e8a4aebab..c363e3ee8f21e0e80a5eb811b744025ddd87e8d6 100644
--- a/content/renderer/child_frame_compositing_helper.cc
+++ b/content/renderer/child_frame_compositing_helper.cc
@@ -205,7 +205,11 @@ void ChildFrameCompositingHelper::OnSetSurface(
surface_layer->SetSurfaceId(surface_id, scale_factor, frame_size);
surface_layer->SetMasksToBounds(true);
- blink::WebLayer* layer = new cc_blink::WebLayerImpl(surface_layer);
+ cc_blink::WebLayerImpl* layer = new cc_blink::WebLayerImpl(surface_layer);
+ // TODO(lfg): Investigate if it's possible to propagate the information about
+ // the child surface's opacity. https://crbug.com/629851.
+ layer->setOpaque(false);
+ layer->SetContentsOpaqueIsFixed(true);
UpdateWebLayer(layer);
UpdateVisibility(true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698