Plumbing for login apps device policy to extensions.

chrome/browser/extensions/policy_handlers.h

Index: chrome/browser/extensions/policy_handlers.h
diff --git a/chrome/browser/extensions/policy_handlers.h b/chrome/browser/extensions/policy_handlers.h
index cd7e5d99cc722a8c678b4ea9be0ab9ea08e2de6e..2483e2ddaff354bbdbf3f73b1c51e2b9cdcd7ba2 100644
--- a/chrome/browser/extensions/policy_handlers.h
+++ b/chrome/browser/extensions/policy_handlers.h
@@ -49,27 +49,54 @@ class ExtensionListPolicyHandler
   DISALLOW_COPY_AND_ASSIGN(ExtensionListPolicyHandler);
 };
 
-class ExtensionInstallForcelistPolicyHandler
+class ExtensionInstallListPolicyHandler

[emaxx, 2017/02/21 19:44:10]

nit: Maybe add comments to explain what this class and the next two ones do?

[achuithb, 2017/02/22 14:39:34]

Done.

     : public policy::TypeCheckingPolicyHandler {
  public:
-  ExtensionInstallForcelistPolicyHandler();
-  ~ExtensionInstallForcelistPolicyHandler() override;
-
   // ConfigurationPolicyHandler methods:
   bool CheckPolicySettings(const policy::PolicyMap& policies,
                            policy::PolicyErrorMap* errors) override;
   void ApplyPolicySettings(const policy::PolicyMap& policies,
                            PrefValueMap* prefs) override;
 
+ protected:
+  ExtensionInstallListPolicyHandler(const char* policy_name,

[emaxx, 2017/02/21 19:44:10]

nit: I believe std::string is used much more often in the Chromium code base.

[achuithb, 2017/02/22 14:39:34]

I'm happy to change this if you insist, but this is not consistent with the type
of policy_name in ExtensionListPolicyHandler. The net effect is that we convert
a const char* to a std::string and need to use c_str() to get a const char* back
immediately.

There's a stronger argument for pref_name, since we're storing this value as an
unowned pointer, but again the type of pref_names::kInstallForceList is const
char[]. It's also a bit weird to have one arg be const char* and the other be
const std::string&.

Let me know what you'd like me to do. My personal inclination is to leave this
as is.

[emaxx, 2017/02/24 04:12:40]

Acknowledged.

+                                    const char* pref_name);
+
+  ~ExtensionInstallListPolicyHandler() override = default;
+
+  const char* pref_name() const { return pref_name_; }
+
  private:
   // Parses the data in |policy_value| and writes them to |extension_dict|.
   bool ParseList(const base::Value* policy_value,
                  base::DictionaryValue* extension_dict,
                  policy::PolicyErrorMap* errors);
 
+  const char* const pref_name_ = nullptr;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstallListPolicyHandler);
+};
+
+class ExtensionInstallForcelistPolicyHandler
+    : public ExtensionInstallListPolicyHandler {
+ public:
+  ExtensionInstallForcelistPolicyHandler();
+  ~ExtensionInstallForcelistPolicyHandler() override = default;
+
+ private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallForcelistPolicyHandler);
 };
 
+class ExtensionInstallLoginlistPolicyHandler
+    : public ExtensionInstallListPolicyHandler {
+ public:
+  ExtensionInstallLoginlistPolicyHandler();
+  ~ExtensionInstallLoginlistPolicyHandler() override = default;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstallLoginlistPolicyHandler);
+};
+
 // Implements additional checks for policies that are lists of extension
 // URLPatterns.
 class ExtensionURLPatternListPolicyHandler