Plumbing for login apps device policy to extensions.

chrome/browser/extensions/policy_handlers.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_POLICY_HANDLERS_H_
 #define CHROME_BROWSER_EXTENSIONS_POLICY_HANDLERS_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/values.h"
 #include "components/policy/core/browser/configuration_policy_handler.h"
 
 namespace policy {
 class PolicyMap;
 class PolicyErrorMap;
 class Schema;
 }  // namespace policy
 
 namespace extensions {
 
 // Implements additional checks for policies that are lists of extension IDs.
 class ExtensionListPolicyHandler
     : public policy::TypeCheckingPolicyHandler {
  public:
   ExtensionListPolicyHandler(const char* policy_name,

[achuithb, 2017/02/22 14:39:34]

Note policy_name is of type const char* here.

                              const char* pref_path,
                              bool allow_wildcards);
   ~ExtensionListPolicyHandler() override;
 
   // ConfigurationPolicyHandler methods:
   bool CheckPolicySettings(const policy::PolicyMap& policies,
                            policy::PolicyErrorMap* errors) override;
   void ApplyPolicySettings(const policy::PolicyMap& policies,
                            PrefValueMap* prefs) override;
 
  protected:
   const char* pref_path() const;
 
   // Runs sanity checks on the policy value and returns it in |extension_ids|.
   bool CheckAndGetList(const policy::PolicyMap& policies,
                        policy::PolicyErrorMap* errors,
                        std::unique_ptr<base::ListValue>* extension_ids);
 
  private:
   const char* pref_path_;
   bool allow_wildcards_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionListPolicyHandler);
 };
 
-class ExtensionInstallForcelistPolicyHandler
+class ExtensionInstallListPolicyHandler

[emaxx, 2017/02/21 19:44:10]

nit: Maybe add comments to explain what this class and the next two ones do?

[achuithb, 2017/02/22 14:39:34]

Done.

     : public policy::TypeCheckingPolicyHandler {
  public:
-  ExtensionInstallForcelistPolicyHandler();
-  ~ExtensionInstallForcelistPolicyHandler() override;
-
   // ConfigurationPolicyHandler methods:
   bool CheckPolicySettings(const policy::PolicyMap& policies,
                            policy::PolicyErrorMap* errors) override;
   void ApplyPolicySettings(const policy::PolicyMap& policies,
                            PrefValueMap* prefs) override;
 
+ protected:
+  ExtensionInstallListPolicyHandler(const char* policy_name,

[emaxx, 2017/02/21 19:44:10]

nit: I believe std::string is used much more often in the Chromium code base.

[achuithb, 2017/02/22 14:39:34]

I'm happy to change this if you insist, but this is not consistent with the type
of policy_name in ExtensionListPolicyHandler. The net effect is that we convert
a const char* to a std::string and need to use c_str() to get a const char* back
immediately.

There's a stronger argument for pref_name, since we're storing this value as an
unowned pointer, but again the type of pref_names::kInstallForceList is const
char[]. It's also a bit weird to have one arg be const char* and the other be
const std::string&.

Let me know what you'd like me to do. My personal inclination is to leave this
as is.

[emaxx, 2017/02/24 04:12:40]

Acknowledged.

+                                    const char* pref_name);
+
+  ~ExtensionInstallListPolicyHandler() override = default;
+
+  const char* pref_name() const { return pref_name_; }
+
  private:
   // Parses the data in |policy_value| and writes them to |extension_dict|.
   bool ParseList(const base::Value* policy_value,
                  base::DictionaryValue* extension_dict,
                  policy::PolicyErrorMap* errors);
 
+  const char* const pref_name_ = nullptr;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstallListPolicyHandler);
+};
+
+class ExtensionInstallForcelistPolicyHandler
+    : public ExtensionInstallListPolicyHandler {
+ public:
+  ExtensionInstallForcelistPolicyHandler();
+  ~ExtensionInstallForcelistPolicyHandler() override = default;
+
+ private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallForcelistPolicyHandler);
 };
 
+class ExtensionInstallLoginlistPolicyHandler
+    : public ExtensionInstallListPolicyHandler {
+ public:
+  ExtensionInstallLoginlistPolicyHandler();
+  ~ExtensionInstallLoginlistPolicyHandler() override = default;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstallLoginlistPolicyHandler);
+};
+
 // Implements additional checks for policies that are lists of extension
 // URLPatterns.
 class ExtensionURLPatternListPolicyHandler
     : public policy::TypeCheckingPolicyHandler {
  public:
   ExtensionURLPatternListPolicyHandler(const char* policy_name,
                                        const char* pref_path);
   ~ExtensionURLPatternListPolicyHandler() override;
 
   // ConfigurationPolicyHandler methods:
@@ skipping 20 matching lines @@
   void ApplyPolicySettings(const policy::PolicyMap& policies,
                            PrefValueMap* prefs) override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsPolicyHandler);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_POLICY_HANDLERS_H_