Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2144263002: [i18n] Make regression test work without i18n. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_issue-cr-627935
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[i18n] Make regression test work without i18n. TBR=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/95ba1af3142ee9ac62b13dc143e5d9925b13b242 Cr-Commit-Position: refs/heads/master@{#37759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M test/mjsunit/regress/regress-crbug-627935.js View 1 chunk +7 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-14 12:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144263002/1
4 years, 5 months ago (2016-07-14 12:27:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 12:29:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95ba1af3142ee9ac62b13dc143e5d9925b13b242 Cr-Commit-Position: refs/heads/master@{#37759}
4 years, 5 months ago (2016-07-14 12:32:58 UTC) #12
Michael Achenbach
4 years, 5 months ago (2016-07-14 13:22:49 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698