Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2143003005: [i18n] Ensure [[ToString]] conversion of time zone names. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[i18n] Ensure [[ToString]] conversion of time zone names. This adds a missing conversion of time zone names to string primitives before case conversion and regular expression matching are applied. This is in sync with ECMA-402, section 12.1.1.1, step 16(a). R=jochen@chromium.org TEST=mjsunit/regress/regress-crbug-627935 BUG=chromium:627935 Committed: https://crrev.com/8226c88b52b8534745228aa0d1c2e822fd14f18d Cr-Commit-Position: refs/heads/master@{#37757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/js/i18n.js View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-627935.js View 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-14 11:02:57 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-14 11:05:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143003005/1
4 years, 5 months ago (2016-07-14 11:21:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19464)
4 years, 5 months ago (2016-07-14 11:25:12 UTC) #9
Jakob Kummerow
lgtm
4 years, 5 months ago (2016-07-14 11:27:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143003005/1
4 years, 5 months ago (2016-07-14 11:29:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 11:31:13 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 11:31:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8226c88b52b8534745228aa0d1c2e822fd14f18d
Cr-Commit-Position: refs/heads/master@{#37757}

Powered by Google App Engine
This is Rietveld 408576698