Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2144213002: ServiceWorkerContainer should override contextDestroyed and clear m_provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
index f57b4ce19dd0583d6a4b47cbbbc1a028a700f7ab..678baafbcf74059548d3860c6080d2bea589f14b 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
@@ -188,8 +188,6 @@ protected:
options.setScope(scope);
ScriptPromise promise = container->registerServiceWorker(getScriptState(), scriptURL, options);
expectRejected(getScriptState(), promise, valueTest);
-
- container->willBeDetachedFromFrame();
haraken 2016/07/14 09:03:53 This is no longer needed because contextDestroyed(
}
void testGetRegistrationRejected(const String& documentURL, const ScriptValueTest& valueTest)
@@ -200,8 +198,6 @@ protected:
ScriptState::Scope scriptScope(getScriptState());
ScriptPromise promise = container->getRegistration(getScriptState(), documentURL);
expectRejected(getScriptState(), promise, valueTest);
-
- container->willBeDetachedFromFrame();
}
private:
@@ -338,8 +334,6 @@ TEST_F(ServiceWorkerContainerTest, RegisterUnregister_NonHttpsSecureOriginDelega
EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/")), stubProvider.registerScope());
EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/worker.js")), stubProvider.registerScriptURL());
}
-
- container->willBeDetachedFromFrame();
}
TEST_F(ServiceWorkerContainerTest, GetRegistration_OmittedDocumentURLDefaultsToPageURL)
@@ -357,8 +351,6 @@ TEST_F(ServiceWorkerContainerTest, GetRegistration_OmittedDocumentURLDefaultsToP
EXPECT_EQ(1ul, stubProvider.getRegistrationCallCount());
EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/index.html")), stubProvider.getRegistrationURL());
}
-
- container->willBeDetachedFromFrame();
}
} // namespace
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698