Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2144153002: [DevTools] Remove CallUID from CPUProfileNode (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
alph, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@make-profile-0-based
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove CallUID from CPUProfileNode - remove callUID from CPUProfileNode in js_protocol; - replace some used object with Map/Set; - better types for closure compiler. R=alph@chromium.org, dgozman@chromium.org Committed: https://crrev.com/4fbe06c4b8da3e7b29f5de86f5970be6e8bd297d Cr-Commit-Position: refs/heads/master@{#405592}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased tests #

Messages

Total messages: 19 (9 generated)
kozy
Alexei, please take a look!
4 years, 5 months ago (2016-07-14 00:56:17 UTC) #1
alph
lgtm
4 years, 5 months ago (2016-07-14 18:06:11 UTC) #2
kozy
Dmitry, please take a look at js_protocol.json. I need owner lgtm.
4 years, 5 months ago (2016-07-14 18:59:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144153002/20001
4 years, 5 months ago (2016-07-14 18:59:46 UTC) #6
dgozman
protocol lgtm
4 years, 5 months ago (2016-07-14 19:06:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/260266)
4 years, 5 months ago (2016-07-14 20:10:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144153002/40001
4 years, 5 months ago (2016-07-14 20:41:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 22:07:34 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:08:00 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:08:47 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4fbe06c4b8da3e7b29f5de86f5970be6e8bd297d
Cr-Commit-Position: refs/heads/master@{#405592}

Powered by Google App Engine
This is Rietveld 408576698