third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js - Issue 2144153002: [DevTools] Remove CallUID from CPUProfileNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js

Issue 2144153002: [DevTools] Remove CallUID from CPUProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-profile-0-based

Patch Set: rebased tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js

index 1658dec7f251ff4f888b13bec888f5312fbc165f..d14ebdefe86abf52a5632aa0594af4add83ac725 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/TopDownProfileDataGrid.js

@@ -66,7 +66,7 @@ WebInspector.TopDownProfileDataGridNode._sharedPopulate = function(container)

/**

* @param {!WebInspector.TopDownProfileDataGridNode|!WebInspector.TopDownProfileDataGridTree} container

- * @param {number|string} aCallUID

+ * @param {string} aCallUID

WebInspector.TopDownProfileDataGridNode._excludeRecursively = function(container, aCallUID)

{

@@ -81,7 +81,7 @@ WebInspector.TopDownProfileDataGridNode._excludeRecursively = function(container

while (index--)

WebInspector.TopDownProfileDataGridNode._excludeRecursively(children[index], aCallUID);

- var child = container.childrenByCallUID[aCallUID];

+ var child = container.childrenByCallUID.get(aCallUID);

if (child)

WebInspector.ProfileDataGridNode.merge(container, child, true);