Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 214413002: Add a port of hb_icu_script_to_script to HarfbuzzShaper (Closed)

Created:
6 years, 9 months ago by jungshik at Google
Modified:
6 years, 9 months ago
CC:
jochen (gone - plz use gerrit), blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Add a port of hb_icu_script_to_script to HarfbuzzShaper Harfbuzz on CrOS does not have hb-icu leading to a compile failure when system_harfbuzz is turned on to avoid a linker warning. (see http://crbug.com/353127). HarfbuzzShaper uses just one function (hb_icu_script_to_script) from hb-icu and it's a simple wrapper. It's ported to HarfbuzzShaper to avoid the dependency on hb-icu. BUG=356929 TEST=content_shell gets built on Linux and no change in layout tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170276

Patch Set 1 #

Total comments: 2

Patch Set 2 : address eae's review comments/nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 1 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jungshik at Google
6 years, 9 months ago (2014-03-27 07:55:00 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-27 08:09:45 UTC) #2
eae
LGTM w/nit https://codereview.chromium.org/214413002/diff/1/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp File Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp (right): https://codereview.chromium.org/214413002/diff/1/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp#newcode761 Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp:761: // without hb-icu. Could you include a ...
6 years, 9 months ago (2014-03-27 16:12:45 UTC) #3
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 9 months ago (2014-03-27 17:36:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/214413002/20001
6 years, 9 months ago (2014-03-27 17:36:52 UTC) #5
jungshik at Google
Thanks for the review. Adding to CQ https://codereview.chromium.org/214413002/diff/1/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp File Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp (right): https://codereview.chromium.org/214413002/diff/1/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp#newcode761 Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp:761: // without ...
6 years, 9 months ago (2014-03-27 17:37:34 UTC) #6
behdad
Grumpy lgtm :)
6 years, 9 months ago (2014-03-27 18:38:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 19:35:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 19:35:32 UTC) #9
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 9 months ago (2014-03-28 04:51:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/214413002/20001
6 years, 9 months ago (2014-03-28 04:51:09 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:01:44 UTC) #12
Message was sent while issue was closed.
Change committed as 170276

Powered by Google App Engine
This is Rietveld 408576698