Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

Issue 214413002: Add a port of hb_icu_script_to_script to HarfbuzzShaper (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address eae's review comments/nits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp
diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp
index 5d8235721d625e967c708b635e8cc55a68ad6d0f..4ac6eb023ffdb21aade197a7c0dcb533c53f75f9 100644
--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp
+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp
@@ -33,16 +33,18 @@
#include "platform/fonts/harfbuzz/HarfBuzzShaper.h"
#include "RuntimeEnabledFeatures.h"
-#include "hb-icu.h"
+#include "hb.h"
#include "platform/fonts/Character.h"
#include "platform/fonts/Font.h"
#include "platform/fonts/harfbuzz/HarfBuzzFace.h"
#include "platform/text/SurrogatePairAwareTextIterator.h"
#include "platform/text/TextBreakIterator.h"
+#include "wtf/Compiler.h"
#include "wtf/MathExtras.h"
#include "wtf/unicode/Unicode.h"
#include <unicode/normlzr.h>
#include <unicode/uchar.h>
+#include <unicode/uscript.h>
#include <list>
#include <map>
@@ -755,6 +757,17 @@ bool HarfBuzzShaper::createHarfBuzzRuns()
return !m_harfBuzzRuns.isEmpty();
}
+// A port of hb_icu_script_to_script because harfbuzz on CrOS is built
+// without hb-icu. See http://crbug.com/356929
+static inline hb_script_t ICUScriptToHBScript(UScriptCode script)
+{
+ if (UNLIKELY(script == USCRIPT_INVALID_CODE))
+ return HB_SCRIPT_INVALID;
+
+ return hb_script_from_string(uscript_getShortName(script), -1);
+}
+
+
void HarfBuzzShaper::addHarfBuzzRun(unsigned startCharacter,
unsigned endCharacter, const SimpleFontData* fontData,
UScriptCode script)
@@ -763,7 +776,7 @@ void HarfBuzzShaper::addHarfBuzzRun(unsigned startCharacter,
ASSERT(script != USCRIPT_INVALID_CODE);
return m_harfBuzzRuns.append(HarfBuzzRun::create(fontData,
startCharacter, endCharacter - startCharacter,
- m_run.direction(), hb_icu_script_to_script(script)));
+ m_run.direction(), ICUScriptToHBScript(script)));
}
static const uint16_t* toUint16(const UChar* src)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698