Issue 2144073005: [css-flexbox] Cache whether our main axis size is definite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2144073005: [css-flexbox] Cache whether our main axis size is definite (Closed)

Created:
4 years, 5 months ago by cbiesinger

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[css-flexbox] Cache whether our main axis size is definite This is an important performance optimization on pages that have a lot of percentage-sized descendants of flexboxes. TEST=n/a, no change in behavior BUG=617792 Review-Url: https://codereview.chromium.org/2056043002 Cr-Commit-Position: refs/heads/master@{#404969} (cherry picked from commit 7f6ee2762d0e5617c17ad828d6353424ca59bacd) Committed: https://chromium.googlesource.com/chromium/src/+/c423bf24146b71a11c3a92932db591bcedeec13d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
	M	third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp	View		5 chunks	+19 lines, -7 lines	0 comments	Download

Total messages: 2 (1 generated)

cbiesinger

4 years, 5 months ago (2016-07-14 18:06:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c423bf24146b71a11c3a92932db591bcedeec13d (tree was closed).