Introduce 'TextCompositionCancel' for cancelComposition

Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
Committed: https://crrev.com/dc5b3fb4ceeeb88b2b5cbdfc8065fae2c73b0d20
Cr-Commit-Position: refs/heads/master@{#435898}

[yabinh, 2016-07-13 09:08:52]

Description was changed from

==========
Split TextCompositionType::TextCompositionConfirm into 2 tags for Issue
2143883002

In this issue, we split TextCompositionType::TextCompositionConfirm into
2 tags: 1)TextCompositionType::TextCompositionConfirm for
InputMethodController::confirmComposition(),
and 2)TextCompositionType::TextCompositionCancel for
InputMethodController::cancelComposition().

It is for the comment in
https://codereview.chromium.org/2143883002/#msg5

BUG=620690
==========

to

==========
Split TextCompositionType::TextCompositionConfirm into 2 tags for Issue
2143883002

In this issue, we split TextCompositionType::TextCompositionConfirm into
2 tags: 1)TextCompositionType::TextCompositionConfirm for
InputMethodController::confirmComposition(),
and 2)TextCompositionType::TextCompositionCancel for
InputMethodController::cancelComposition().

It is for the comment in
https://codereview.chromium.org/2143883002/#msg5

BUG=620690
==========

[yabinh, 2016-07-13 09:11:15]

yabinh@chromium.org changed reviewers:
+ aelias@chromium.org, changwan@chromium.org, yosin@chromium.org

[yabinh, 2016-07-13 09:11:15]

yosin@, can you take a look at this cl?

[yosin_UTC9, 2016-07-14 01:18:28]

On 2016/07/13 at 09:11:15, yabinh wrote:
> yosin@, can you take a look at this cl?

Sorry, I don't understand the reason why introducing TextCompositionCancel fixes
U+0C03 issue.
I think we should change PlainTextRange::createRange() to return a range in
graphme boundary rather than code point.
See |{next,previous}PositionOf()| and |PositionMoveType|.

[Changwan Ryu, 2016-07-14 02:01:16]

On 2016/07/14 01:18:28, Yosi_UTC9 wrote:
> On 2016/07/13 at 09:11:15, yabinh wrote:
> > yosin@, can you take a look at this cl?
> 
> Sorry, I don't understand the reason why introducing TextCompositionCancel
fixes
> U+0C03 issue.
> I think we should change PlainTextRange::createRange() to return a range in
> graphme boundary rather than code point.
> See |{next,previous}PositionOf()| and |PositionMoveType|.

yosin@, at least for Android, the offsets should be in UTF-16 code points, and
not grapheme clusters.
https://developer.android.com/reference/android/view/inputmethod/InputConnect...
The above spec refers to generic Java 'characters' and 'strings'. If we count
multiple code points as one grapheme cluster, keyboard apps won't be able to
understand the offsets.

IIUC, handleTextInput() tries to canonicalize the visible selection to avoid
selection to be in the middle of grapheme cluster. (probably in preparation for
interacting with event listeners?). But they're doing it wrong because Unicode
rule is too simplistic, and that's something yabinh@ tries to work around in his
original CL.

[Changwan Ryu, 2016-07-14 02:03:09]

On 2016/07/14 02:01:16, Changwan Ryu wrote:
> On 2016/07/14 01:18:28, Yosi_UTC9 wrote:
> > On 2016/07/13 at 09:11:15, yabinh wrote:
> > > yosin@, can you take a look at this cl?
> > 
> > Sorry, I don't understand the reason why introducing TextCompositionCancel
> fixes
> > U+0C03 issue.
> > I think we should change PlainTextRange::createRange() to return a range in
> > graphme boundary rather than code point.
> > See |{next,previous}PositionOf()| and |PositionMoveType|.
> 
> yosin@, at least for Android, the offsets should be in UTF-16 code points, and
> not grapheme clusters.
>
https://developer.android.com/reference/android/view/inputmethod/InputConnect...
> The above spec refers to generic Java 'characters' and 'strings'. If we count
> multiple code points as one grapheme cluster, keyboard apps won't be able to
> understand the offsets.
> 
> IIUC, handleTextInput() tries to canonicalize the visible selection to avoid
> selection to be in the middle of grapheme cluster. (probably in preparation
for
> interacting with event listeners?). But they're doing it wrong because Unicode
> rule is too simplistic, and that's something yabinh@ tries to work around in
his
> original CL.

yabinh@, please make this CL description as self-contained as possible.

[yabinh, 2016-07-14 02:25:26]

Description was changed from

==========
Split TextCompositionType::TextCompositionConfirm into 2 tags for Issue
2143883002

In this issue, we split TextCompositionType::TextCompositionConfirm into
2 tags: 1)TextCompositionType::TextCompositionConfirm for
InputMethodController::confirmComposition(),
and 2)TextCompositionType::TextCompositionCancel for
InputMethodController::cancelComposition().

It is for the comment in
https://codereview.chromium.org/2143883002/#msg5

BUG=620690
==========

to

==========
Split TextCompositionType::TextCompositionConfirm into 2 tags for Issue
2143883002

InputMethodController::cancelComposition() and
InputMethodController::confirmComposition() share the same tag 
"TextCompositionConfirm". We want to change the behavior of
confirmComposition(), and keep cancelComposition() unchanged. In order to
do that, we split 1 tag into 2 tags, then assign them to cancelComposition()
and confirmComposition() accordingly.

BUG=620690
==========

[yabinh, 2016-07-14 02:31:20]

Description was changed from

==========
Split TextCompositionType::TextCompositionConfirm into 2 tags for Issue
2143883002

InputMethodController::cancelComposition() and
InputMethodController::confirmComposition() share the same tag 
"TextCompositionConfirm". We want to change the behavior of
confirmComposition(), and keep cancelComposition() unchanged. In order to
do that, we split 1 tag into 2 tags, then assign them to cancelComposition()
and confirmComposition() accordingly.

BUG=620690
==========

to

==========
Introduce TextCompositionType::TextCompositionCancel  for
InputMethodController::cancelComposition()

InputMethodController::cancelComposition() and
InputMethodController::confirmComposition() share the same tag 
"TextCompositionConfirm". We want to change the behavior of
confirmComposition(), and keep cancelComposition() unchanged. In order to
do that, we introduce TextCompositionType::TextCompositionCancel for
cancelComposition().

BUG=620690
==========

[yabinh, 2016-11-25 02:48:53]

Description was changed from

==========
Introduce TextCompositionType::TextCompositionCancel  for
InputMethodController::cancelComposition()

InputMethodController::cancelComposition() and
InputMethodController::confirmComposition() share the same tag 
"TextCompositionConfirm". We want to change the behavior of
confirmComposition(), and keep cancelComposition() unchanged. In order to
do that, we introduce TextCompositionType::TextCompositionCancel for
cancelComposition().

BUG=620690
==========

to

==========
Make setComposition and finishComposingText respect existing style(1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-25 02:49:28]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style(1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition and finishComposingText respect existing style(1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-25 02:52:33]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 02:52:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 03:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 03:59:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yabinh, 2016-11-25 04:17:16]

yabinh@chromium.org changed reviewers:
- yosin@chromium.org

[yabinh, 2016-11-25 04:21:40]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 04:21:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-11-25 04:23:29]

Removing yosin@ until this CL gets stable.

changwan@, PTAL.

[yabinh, 2016-11-25 04:37:08]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style(1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-25 04:37:50]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition() and other functions (e.g confirmComposingText()) share the
same tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition(), and assign the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition, and assign the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-25 04:38:32]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep change the former's behavior
and change the others', this CL introduces "TextCompositionCancel" for
cancelComposition, and assign the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assign the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-25 04:38:55]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assign the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

[commit-bot: I haz the power, 2016-11-25 05:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 05:05:43]

Dry run: This issue passed the CQ dry run.

[yabinh, 2016-11-28 08:06:57]

Description was changed from

==========
Make setComposition and finishComposingText respect existing style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition, finishComposingText and commitText respect existing
style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-11-28 08:08:14]

Description was changed from

==========
Make setComposition, finishComposingText and commitText respect existing
style (1/2)

cancelComposition and other functions (e.g confirmComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

to

==========
Make setComposition, finishComposingText and commitText respect existing
style (1/2)

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

[yabinh, 2016-12-02 08:17:47]

Description was changed from

==========
Make setComposition, finishComposingText and commitText respect existing
style (1/2)

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions.

BUG=620549
==========

to

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

[yabinh, 2016-12-02 08:17:47]

yabinh@chromium.org changed reviewers:
+ yosin@chromium.org

[yabinh, 2016-12-02 08:18:02]

Description was changed from

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

to

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
 https://codereview.chromium.org/2530843003/

BUG=620549
==========

[yabinh, 2016-12-02 08:18:14]

Description was changed from

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
 https://codereview.chromium.org/2530843003/

BUG=620549
==========

to

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

[yabinh, 2016-12-02 08:22:35]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 08:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-12-02 08:51:21]

lgtm

[yabinh, 2016-12-02 08:57:50]

The CQ bit was unchecked by yabinh@chromium.org

[yabinh, 2016-12-02 08:57:51]

The CQ bit was checked by yabinh@chromium.org

[commit-bot: I haz the power, 2016-12-02 08:58:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-12-02 08:59:51]

The CQ bit was unchecked by yabinh@chromium.org

[yabinh, 2016-12-02 09:00:23]

Description was changed from

==========
Introduce 'TextCompositionConfirm' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

to

==========
Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

[yabinh, 2016-12-02 09:00:39]

The CQ bit was checked by yabinh@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:03:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480669239808560,
"parent_rev": "1e37331259782e463555ce52fda1b08a429c5635", "commit_rev":
"3de8ee0333ba0fe7a072f64c6f6da14629d6c785"}

[commit-bot: I haz the power, 2016-12-02 10:03:29]

Description was changed from

==========
Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

to

==========
Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

[commit-bot: I haz the power, 2016-12-02 10:03:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 10:06:07]

Description was changed from

==========
Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549
==========

to

==========
Introduce 'TextCompositionCancel' for cancelComposition

cancelComposition and other functions (e.g finishComposingText) share the same
tag "TextCompositionConfirm". In order to keep the former's behavior and change
the others', this CL introduces "TextCompositionCancel" for cancelComposition,
and assigns the old tag to other functions. This is a pre-CL for
https://codereview.chromium.org/2530843003/

BUG=620549

Committed: https://crrev.com/dc5b3fb4ceeeb88b2b5cbdfc8065fae2c73b0d20
Cr-Commit-Position: refs/heads/master@{#435898}
==========

[commit-bot: I haz the power, 2016-12-02 10:06:08]

Patchset 3 (id:??) landed as
https://crrev.com/dc5b3fb4ceeeb88b2b5cbdfc8065fae2c73b0d20
Cr-Commit-Position: refs/heads/master@{#435898}