Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2143703002: Enable find in page buttons based on search text rather than match (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable find in page buttons based on search text rather than match results. When you re-open the find bar and it's prepopulated with a previous search, we don't execute a search until you press enter or next/previous. Before this patch, next/previous was disabled when you have prepopulated search text but no actual search. BUG=627356 Committed: https://crrev.com/4490a847784c16a5277604afdfe59b8dae66310d Cr-Commit-Position: refs/heads/master@{#405205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 5 months ago (2016-07-12 18:09:49 UTC) #2
msw
lgtm
4 years, 5 months ago (2016-07-12 18:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143703002/1
4 years, 5 months ago (2016-07-12 18:49:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191626)
4 years, 5 months ago (2016-07-12 21:28:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143703002/1
4 years, 5 months ago (2016-07-13 16:39:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:12:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:14:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4490a847784c16a5277604afdfe59b8dae66310d
Cr-Commit-Position: refs/heads/master@{#405205}

Powered by Google App Engine
This is Rietveld 408576698