chrome/browser/ui/views/find_bar_view.cc - Issue 2143703002: Enable find in page buttons based on search text rather than match

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 2143703002: Enable find in page buttons based on search text rather than match (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/find_bar_view.cc

diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc

index 7ff6b561d857fabb00781b00222af6b663cf4b50..002e56cae81e70d80d94a68020b51a5439e755f6 100644

--- a/chrome/browser/ui/views/find_bar_view.cc

+++ b/chrome/browser/ui/views/find_bar_view.cc

@@ -594,7 +594,7 @@ void FindBarView::Find(const base::string16& search_text) {

}

void FindBarView::UpdateMatchCountAppearance(bool no_match) {

- bool enable_buttons = !match_count_text_->text().empty() && !no_match;

+ bool enable_buttons = !find_text_->text().empty() && !no_match;

find_previous_button_->SetEnabled(enable_buttons);

find_next_button_->SetEnabled(enable_buttons);

« no previous file with comments | « no previous file | no next file » | no next file with comments »