Remove didAutoResize from WebWidgetClient and move it to WebViewClient..

Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
Committed: https://crrev.com/b00fcadffc41253ea0626c1bdaeb3a4c60e6ec7c
Cr-Commit-Position: refs/heads/master@{#405489}

[lfg, 2016-07-12 17:53:15]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-07-12 17:53:15]

PTAL.

[lfg, 2016-07-12 17:54:04]

Description was changed from

==========
Remove didAutoResize from WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[dcheng, 2016-07-13 14:17:24]

blink lgtm

https://codereview.chromium.org/2143643002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2143643002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2021:
RenderWidget::DidAutoResize(new_size);
I'm pretty sure you can just pass newSize directly here: it has a conversion
operator to gfx::Size.

https://codereview.chromium.org/2143643002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebViewClient.h (right):

https://codereview.chromium.org/2143643002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:114: virtual void
didAutoResize(const WebSize& newSize) {}
Nit: I think this probably belongs under the "UI" section (it's also somewhat of
a generic dumping ground of stuff, but slightly less generic than "misc")

[lfg, 2016-07-13 17:29:27]

https://codereview.chromium.org/2143643002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2143643002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2021:
RenderWidget::DidAutoResize(new_size);
On 2016/07/13 14:17:24, dcheng wrote:
> I'm pretty sure you can just pass newSize directly here: it has a conversion
> operator to gfx::Size.

Done.

https://codereview.chromium.org/2143643002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebViewClient.h (right):

https://codereview.chromium.org/2143643002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:114: virtual void
didAutoResize(const WebSize& newSize) {}
On 2016/07/13 14:17:24, dcheng wrote:
> Nit: I think this probably belongs under the "UI" section (it's also somewhat
of
> a generic dumping ground of stuff, but slightly less generic than "misc")

Done.

[lfg, 2016-07-13 17:29:50]

lfg@chromium.org changed reviewers:
+ avi@chromium.org

[lfg, 2016-07-13 17:29:51]

avi@chromium.org: Please review changes in 

content/

[Avi (use Gerrit), 2016-07-13 18:04:37]

lgtm

[lfg, 2016-07-13 18:05:23]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 18:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:09:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lfg, 2016-07-13 22:37:12]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 01:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:43:08]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-07-14 14:12:20]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-07-14 14:12:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2143643002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-14 14:12:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 14:16:46]

Description was changed from

==========
Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[commit-bot: I haz the power, 2016-07-14 14:16:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 14:16:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 14:18:16]

Description was changed from

==========
Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove didAutoResize from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Committed: https://crrev.com/b00fcadffc41253ea0626c1bdaeb3a4c60e6ec7c
Cr-Commit-Position: refs/heads/master@{#405489}
==========

[commit-bot: I haz the power, 2016-07-14 14:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/b00fcadffc41253ea0626c1bdaeb3a4c60e6ec7c
Cr-Commit-Position: refs/heads/master@{#405489}