Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2143643002: Remove didAutoResize from WebWidgetClient and move it to WebViewClient.. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 // This method enumerates all the files in the path. It returns immediately 104 // This method enumerates all the files in the path. It returns immediately
105 // and asynchronously invokes the WebFileChooserCompletion with all the 105 // and asynchronously invokes the WebFileChooserCompletion with all the
106 // files in the directory. Returns false if the WebFileChooserCompletion 106 // files in the directory. Returns false if the WebFileChooserCompletion
107 // will never be called. 107 // will never be called.
108 virtual bool enumerateChosenDirectory(const WebString& path, WebFileChooserC ompletion*) { return false; } 108 virtual bool enumerateChosenDirectory(const WebString& path, WebFileChooserC ompletion*) { return false; }
109 109
110 // Called when PageImportanceSignals for the WebView is updated. 110 // Called when PageImportanceSignals for the WebView is updated.
111 virtual void pageImportanceSignalsChanged() { } 111 virtual void pageImportanceSignalsChanged() { }
112 112
113 // Called when the View has changed size as a result of an auto-resize.
114 virtual void didAutoResize(const WebSize& newSize) {}
dcheng 2016/07/13 14:17:24 Nit: I think this probably belongs under the "UI"
lfg 2016/07/13 17:29:27 Done.
115
113 // Editing ------------------------------------------------------------- 116 // Editing -------------------------------------------------------------
114 117
115 // These methods allow the client to intercept and overrule editing 118 // These methods allow the client to intercept and overrule editing
116 // operations. 119 // operations.
117 virtual void didCancelCompositionOnSelectionChange() { } 120 virtual void didCancelCompositionOnSelectionChange() { }
118 virtual void didChangeContents() { } 121 virtual void didChangeContents() { }
119 122
120 // This method is called in response to WebView's handleInputEvent() 123 // This method is called in response to WebView's handleInputEvent()
121 // when the default action for the current keyboard event is not 124 // when the default action for the current keyboard event is not
122 // suppressed by the page, to give the embedder a chance to handle 125 // suppressed by the page, to give the embedder a chance to handle
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 // Informs the browser that the draggable regions have been updated. 250 // Informs the browser that the draggable regions have been updated.
248 virtual void draggableRegionsChanged() { } 251 virtual void draggableRegionsChanged() { }
249 252
250 // TODO(lfg): These methods are only exposed through WebViewClient while we 253 // TODO(lfg): These methods are only exposed through WebViewClient while we
251 // refactor WebView to not inherit from WebWidget. 254 // refactor WebView to not inherit from WebWidget.
252 // WebWidgetClient overrides. 255 // WebWidgetClient overrides.
253 bool allowsBrokenNullLayerTreeView() const override { return false; } 256 bool allowsBrokenNullLayerTreeView() const override { return false; }
254 void closeWidgetSoon() override {} 257 void closeWidgetSoon() override {}
255 void convertViewportToWindow(WebRect* rect) override {} 258 void convertViewportToWindow(WebRect* rect) override {}
256 void convertWindowToViewport(WebFloatRect* rect) override {} 259 void convertWindowToViewport(WebFloatRect* rect) override {}
257 void didAutoResize(const WebSize& newSize) override {}
258 void didChangeCursor(const WebCursorInfo&) override {} 260 void didChangeCursor(const WebCursorInfo&) override {}
259 void didFocus() override {} 261 void didFocus() override {}
260 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {} 262 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {}
261 void didInvalidateRect(const WebRect&) override {} 263 void didInvalidateRect(const WebRect&) override {}
262 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {} 264 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {}
263 void didUpdateTextOfFocusedElementByNonUserInput() override {} 265 void didUpdateTextOfFocusedElementByNonUserInput() override {}
264 void hasTouchEventHandlers(bool) override {} 266 void hasTouchEventHandlers(bool) override {}
265 void initializeLayerTreeView() override {} 267 void initializeLayerTreeView() override {}
266 WebLayerTreeView* layerTreeView() override { return 0; } 268 WebLayerTreeView* layerTreeView() override { return 0; }
267 void onMouseDown(const WebNode& mouseDownNode) override {} 269 void onMouseDown(const WebNode& mouseDownNode) override {}
(...skipping 10 matching lines...) Expand all
278 WebRect windowRect() override { return WebRect(); } 280 WebRect windowRect() override { return WebRect(); }
279 WebRect windowResizerRect() override { return WebRect(); } 281 WebRect windowResizerRect() override { return WebRect(); }
280 282
281 protected: 283 protected:
282 ~WebViewClient() { } 284 ~WebViewClient() { }
283 }; 285 };
284 286
285 } // namespace blink 287 } // namespace blink
286 288
287 #endif 289 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698