Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2143533002: Rename player => animation in ready promise test (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename player => animation in ready promise test Rename player => animation in ready promise test BUG=623437 Committed: https://crrev.com/f8f67bb5d779485ad13daa1ee42268a2e90642b7 Cr-Commit-Position: refs/heads/master@{#404786}

Patch Set 1 #

Patch Set 2 : name changes #

Patch Set 3 : Diff should show changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -89 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-ready-promise.html View 1 2 1 chunk +93 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/player-ready-promise.html View 1 chunk +0 lines, -89 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nainar
4 years, 5 months ago (2016-07-12 03:16:55 UTC) #3
suzyh_UTC10 (ex-contributor)
Have you checked for overlap in interfaces/Animation/ready.html?
4 years, 5 months ago (2016-07-12 03:54:26 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 03:57:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143533002/40001
4 years, 5 months ago (2016-07-12 04:00:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-12 05:39:31 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 05:39:40 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 05:40:41 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8f67bb5d779485ad13daa1ee42268a2e90642b7
Cr-Commit-Position: refs/heads/master@{#404786}

Powered by Google App Engine
This is Rietveld 408576698