Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2143493002: Revert of Add setup.py to infra_libs (Closed)

Created:
4 years, 5 months ago by Sergey Berezin
Modified:
4 years, 5 months ago
Reviewers:
iannucci, tnn
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of Add setup.py to infra_libs (patchset #1 id:1 of https://codereview.chromium.org/2129103004/ ) Reason for revert: I think I rushed it - setup.py doesn't really work without a deeper module structure. It needs to be next to infra_libs, not inside it. Original issue's description: > Add setup.py to infra_libs > > This is to allow creating a correct wheel out of it, for use with glyco > and in the future, possibly pip / PyPI. > > BUG=626741 > TBR=iannucci@chromium.org > > Committed: https://chromium.googlesource.com/infra/infra/+/02a515dab9ac003e22daa2ff5cbde5b1cd0c45e1 TBR=iannucci@chromium.org,tanin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626741 Committed: https://chromium.googlesource.com/infra/infra/+/eef9e96933a2f494f5a98172350786384d6da15a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
D infra_libs/setup.py View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sergey Berezin
Created Revert of Add setup.py to infra_libs
4 years, 5 months ago (2016-07-11 22:59:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143493002/1
4 years, 5 months ago (2016-07-11 22:59:15 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 22:59:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/eef9e96933a2f494f5a9817235078...

Powered by Google App Engine
This is Rietveld 408576698