Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2129103004: Add setup.py to infra_libs (Closed)

Created:
4 years, 5 months ago by Sergey Berezin
Modified:
4 years, 5 months ago
Reviewers:
iannucci, tnn
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Add setup.py to infra_libs This is to allow creating a correct wheel out of it, for use with glyco and in the future, possibly pip / PyPI. BUG=626741 TBR=iannucci@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/02a515dab9ac003e22daa2ff5cbde5b1cd0c45e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A infra_libs/setup.py View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Berezin
PTAL. Tested with $ ./glyco/glyco pack -o ~/glyco_wheels infra_libs $ ./glyco/glyco install -i test_install ~/glyco_wheels/infra_libs-1.1.0-* ...
4 years, 5 months ago (2016-07-09 00:21:47 UTC) #1
Sergey Berezin
+tanin - FYI.
4 years, 5 months ago (2016-07-11 16:26:59 UTC) #3
Sergey Berezin
TBR'ing this - it won't break anything, but I need it to roll ts_mon in ...
4 years, 5 months ago (2016-07-11 18:40:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129103004/1
4 years, 5 months ago (2016-07-11 18:40:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/02a515dab9ac003e22daa2ff5cbde5b1cd0c45e1
4 years, 5 months ago (2016-07-11 18:56:49 UTC) #9
Sergey Berezin
4 years, 5 months ago (2016-07-11 22:59:11 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2143493002/ by sergeyberezin@chromium.org.

The reason for reverting is: I think I rushed it - setup.py doesn't really work
without a deeper module structure. It needs to be next to infra_libs, not inside
it..

Powered by Google App Engine
This is Rietveld 408576698