Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2143483004: [DevTools] Fix v8_inspector compilation with node (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix v8_inspector compilation with node R=dgozman@chromium.org,pfeldman@chromium.org,eostroukhov@google.com NOTRY=true Committed: https://crrev.com/d8a572d4784ba224090e13e5ee8c7c3884063a3c Cr-Commit-Position: refs/heads/master@{#404834}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 32 (18 generated)
kozy
please take a look! https://codereview.chromium.org/2143483004/diff/1/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h File third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h (right): https://codereview.chromium.org/2143483004/diff/1/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h#newcode9 third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h:9: #include "platform/inspector_protocol/Platform.h" For std::unique_ptr https://codereview.chromium.org/2143483004/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ...
4 years, 5 months ago (2016-07-12 00:32:39 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-12 00:37:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 01:18:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242179) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 02:48:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 03:29:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190859) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 05:34:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 05:37:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253807)
4 years, 5 months ago (2016-07-12 06:57:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 15:10:08 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191341)
4 years, 5 months ago (2016-07-12 17:15:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 18:43:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483004/1
4 years, 5 months ago (2016-07-12 19:47:22 UTC) #28
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 20:52:20 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 20:53:49 UTC) #32
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d8a572d4784ba224090e13e5ee8c7c3884063a3c
Cr-Commit-Position: refs/heads/master@{#404834}

Powered by Google App Engine
This is Rietveld 408576698