Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp

Issue 2143483004: [DevTools] Fix v8_inspector compilation with node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp
index fadab16d7ebd1edaa87cad73507c0e67e5b21d13..f118dcacf3ce5ada0a566616a599189d10be2712 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp
@@ -13,6 +13,7 @@
namespace blink {
V8Inspector::V8Inspector(v8::Isolate* isolate, v8::Local<v8::Context> context)
+ : m_context(context)
{
m_debugger = V8Debugger::create(isolate, this);
m_debugger->contextCreated(V8ContextInfo(context, 1, true, "",
@@ -55,21 +56,17 @@ void V8Inspector::dispatchMessageFromFrontend(const String16& message)
m_session->dispatchProtocolMessage(message);
}
-int V8Inspector::ensureDefaultContextInGroup(int contextGroupId)
+v8::Local<v8::Context> V8Inspector::ensureDefaultContextInGroup(int)
{
- return 1;
+ return m_context;
}
-void V8Inspector::muteConsole()
-{
-}
-
-void V8Inspector::unmuteConsole()
+bool V8Inspector::isExecutionAllowed()
{
-
+ return true;
}
-bool V8Inspector::isExecutionAllowed()
+bool V8Inspector::canExecuteScripts()
{
return true;
}

Powered by Google App Engine
This is Rietveld 408576698