third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp - Issue 2143483002: Use the single char overload of append() when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentAddress.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

index fe119e1d90e71cafc063f480d818db256339e69d..573f455990c7620f43d4a7a375df6760d3cea2ad 100644

--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

@@ -85,13 +85,13 @@ static bool throwExceptionIfRemovedOrUpdating(bool isRemoved, bool isUpdating, E

WTF::String webTimeRangesToString(const WebTimeRanges& ranges)

{

StringBuilder stringBuilder;

- stringBuilder.append("{");

+ stringBuilder.append('{');

for (auto& r : ranges) {

stringBuilder.append(" [");

stringBuilder.appendNumber(r.start);

- stringBuilder.append(";");

+ stringBuilder.append(';');

stringBuilder.appendNumber(r.end);

- stringBuilder.append("]");

+ stringBuilder.append(']');

}

stringBuilder.append(" }");

return stringBuilder.toString();