Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214343006: Check shared memory size before allocating it. (Closed)

Created:
6 years, 8 months ago by wjia(left Chromium)
Modified:
6 years, 8 months ago
Reviewers:
jschuh
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Check shared memory size before allocating it. This will prevent overflow from multiplication. BUG=359454 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wjia(left Chromium)
6 years, 8 months ago (2014-04-03 17:51:17 UTC) #1
jschuh
lgtm
6 years, 8 months ago (2014-04-03 18:03:32 UTC) #2
wjia(left Chromium)
The CQ bit was checked by wjia@chromium.org
6 years, 8 months ago (2014-04-03 18:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjia@chromium.org/214343006/1
6 years, 8 months ago (2014-04-03 18:14:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 22:15:46 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 22:15:46 UTC) #6
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 8 months ago (2014-04-03 22:21:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjia@chromium.org/214343006/1
6 years, 8 months ago (2014-04-03 22:21:23 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 22:23:47 UTC) #9
Message was sent while issue was closed. 
Change committed as 261549

Powered by Google App Engine
This is Rietveld 408576698