Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2143353004: Revert of Add MemoryCoordinator (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, chrisha, jam, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org, darin (slow to review), ben+mojo_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add MemoryCoordinator (patchset #13 id:240001 of https://codereview.chromium.org/2094583002/ ) Reason for revert: Broke mac build Original issue's description: > Add MemoryCoordinator > > This CL adds MemoryCoordinator mojo interface and > its implementation. When --enable-features=MemoryCoordinator > is specified the browser and renderers create their > MemoryCoordinators. MemoryCoordinatorImpl (which lives in > the browser process) creates a mojo message pipe when a > renderer is launched. > > This CL doesn't add actual handling of memory events, which > will be implemented in follow-up CLs. > > BUG=617492 > > Committed: https://crrev.com/066dcbbad57a70ba5380a4a8cdd0572d89bdc279 > Cr-Commit-Position: refs/heads/master@{#405402} TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617492 Committed: https://crrev.com/d0fc7bbda13afe0f382463970efb251518dd898c Cr-Commit-Position: refs/heads/master@{#405406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -350 lines) Patch
M components/memory_coordinator.gypi View 2 chunks +1 line, -19 lines 0 comments Download
M components/memory_coordinator/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/memory_coordinator/browser/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M components/memory_coordinator/child/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 2 chunks +6 lines, -14 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/memory_coordinator/public/interfaces/memory_coordinator.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
Created Revert of Add MemoryCoordinator
4 years, 5 months ago (2016-07-14 02:34:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143353004/1
4 years, 5 months ago (2016-07-14 02:35:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 02:36:17 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-07-14 02:36:48 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:37:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0fc7bbda13afe0f382463970efb251518dd898c
Cr-Commit-Position: refs/heads/master@{#405406}

Powered by Google App Engine
This is Rietveld 408576698