cc: Remove OutputSurfaceClient::DidSwapBuffers().

cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4600da1be6cc2719af18c4cbdc07101e1ba77127
Cr-Commit-Position: refs/heads/master@{#405300}

[danakj, 2016-07-12 22:42:56]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

R=enne, jbauman
BUG=606056
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

R=enne, jbauman
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-12 22:43:29]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

R=enne, jbauman
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
BUG=606056
==========

[danakj, 2016-07-12 22:44:08]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org, fsamuel@chromium.org, sievers@chromium.org

[danakj, 2016-07-12 22:44:08]

+sievers for content
+boliu for webview
+fsamuel for mus

[danakj, 2016-07-12 22:44:38]

danakj@chromium.org changed reviewers:
+ nyquist@chromium.org

[danakj, 2016-07-12 22:44:39]

+nyquist for blimp

[danakj, 2016-07-12 22:45:15]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-07-12 22:45:16]

+sky for services/ui/public/cpp/lib/output_surface.cc

[danakj, 2016-07-12 22:45:31]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-07-12 22:45:39]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
BUG=606056
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky
BUG=606056
==========

[jbauman, 2016-07-12 22:48:10]

lgtm

[commit-bot: I haz the power, 2016-07-12 22:48:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-07-12 23:15:37]

Nice! lgtm

[Fady Samuel, 2016-07-12 23:21:51]

services/ui/surfaces lgtm

[nyquist, 2016-07-12 23:52:12]

lgtm

[commit-bot: I haz the power, 2016-07-12 23:55:45]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:55:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2016-07-12 23:59:10]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky
BUG=606056
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-12 23:59:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-07-13 00:00:12]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-13 00:00:23]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-07-13 00:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
nyquist@chromium.org, jbauman@chromium.org, fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2143263002/#ps20001
(title: "removedidswap: testfix")

[danakj, 2016-07-13 00:00:34]

TBRing the rest, just deleting stuff.

[commit-bot: I haz the power, 2016-07-13 00:05:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-07-13 00:31:55]

lgtm

[commit-bot: I haz the power, 2016-07-13 01:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 01:12:26]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2016-07-13 01:14:51]

I missed a call to DidSwapBuffers looks like.

07-13 00:56:56.849 10350 10368 F chromium: [FATAL:scheduler.cc(162)] Check
failed: state_machine_.pending_swaps() > 0 (0 vs.
0){"compositor_timing_history":{"activate_estimate_ms":0.301,"begin_main_frame_queue_critical_estimate_ms":0.143,"begin_main_frame_queue_not_critical_estimate_ms":0.143,"begin_main_frame_start_to_commit_estimate_ms":1.506,"commit_to_ready_to_activate_estimate_ms":0.311,"draw_estimate_ms":0.0,"prepare_tiles_estimate_ms":0.11},"scheduler_state":{"begin_impl_frame_args":{"current_args_":{"deadline_us":0.0,"frame_time_us":2935856502.0,"interval_us":16666.0,"on_critical_path":true,"subtype":"NORMAL","type":"BeginFrameArgs"},"finished_at_us":-1359096954,"major_timestamps_in_ms":{"0_interval":16.666,"1_now_to_deadline":-2935970.846,"2_frame_time_to_now":114.344,"3_frame_time_to_deadline":-2935856.502,"4_now":2935970.846,"5_frame_time":2935856.502,"6_deadline":0.0},"state":"FINISHED","updated_at_us":-1359098295},"begin_impl_frame_deadline_mode_":"BEGIN_IMPL_FRAME_DEADLINE_MODE_NONE","begin_impl_frame_deadline_task":false,"begin_retro_frame_args":0,"begin_retro_frame_task":false,"estimated_parent_draw_time_ms":0.0,"inside_action":"ACTION_DRAW_AND_SWAP_IF_POSSIBLE","observing_begin_frame_source":true,"throttle_frame_production_":true},"state_machine":{"major_state":{"begin_impl_frame_state":"BEGIN_IMPL_FRAME_STATE_INSIDE_DEADLINE","begin_main_frame_state":"BEGIN_MAIN_FRAME_STATE_IDLE","forced_redraw_state":"FORCED_REDRAW_STATE_IDLE","next_action":"ACTION_PREPARE_TILES","output_surface_state_":"OUTPUT_SURFACE_ACTIVE"},"minor_state":{"active_tree_needs_first_draw":false,"begin_frame_source_paused":false,"can_draw":true,"commit_count":1,"consecutive_checkerboard_animations":0,"critical_begin_main_frame_to_activate_is_fast_":false,"current_frame_number":1,"defer_commits":false,"did_create_and_initialize_first_output_surface":true,"did_draw_in_last_frame":true,"did_swap_in_last_frame":false,"funnel:
draw_funnel":true,"funnel: invalidate_output_surface_funnel":true,"funnel:
prepare_tiles_funnel":0,"funnel:
send_begin_main_frame_funnel":true,"has_pending_tree":false,"last_commit_had_no_updates":false,"last_frame_number_begin_main_frame_sent":1,"last_frame_number_draw_performed":1,"last_frame_number_swap_performed":-1,"main_thread_missed_last_deadline":false,"needs_begin_main_frame":false,"needs_one_begin_impl_frame":false,"needs_prepare_tiles":true,"needs_redraw":false,"pending_swaps_":0,"pending_tree_is_ready_for_activation":false,"resourceless_draw":true,"scroll_handler_state":"SCROLL_DOES_NOT_AFFECT_SCROLL_HANDLER","skip_next_begin_main_frame_to_reduce_latency":false,"swaps_with_current_output_surface":0,"tree_priority":"SAME_PRIORITY_FOR_BOTH_TREES","video_needs_begin_frames":false,"visible":true,"wait_for_ready_to_draw":false}}}

[piman, 2016-07-13 18:29:54]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-07-13 18:29:55]

lgtm

[danakj, 2016-07-13 19:56:12]

boliu: PTAL, fix for webview included.

That fallback tick thing we did in SwapBuffers, where it calls
DidSwapBuffersCompleted
right away.. that breaks us here, because it calls the completed inside the
stack
before returning. Which means the completed comes before the swap notification
making
it unmatched. We should use the did_swap_ = true thing, which exists for the
same
reasons I'm pretty sure. Added a comment too.

[danakj, 2016-07-13 19:56:19]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:57:34]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.blink. For more details, see http://crbug.com/617627.

[danakj, 2016-07-13 19:59:48]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
==========

[boliu, 2016-07-13 20:01:52]

On 2016/07/13 19:56:12, danakj wrote:
> boliu: PTAL, fix for webview included.
> 
> That fallback tick thing we did in SwapBuffers, where it calls
> DidSwapBuffersCompleted
> right away.. that breaks us here, because it calls the completed inside the
> stack
> before returning. Which means the completed comes before the swap notification
> making
> it unmatched. We should use the did_swap_ = true thing, which exists for the
> same
> reasons I'm pretty sure. Added a comment too.

lgtm

[danakj, 2016-07-13 20:02:52]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-13 20:03:02]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-07-13 20:03:10]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-07-13 20:03:10]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
nyquist@chromium.org, jbauman@chromium.org, fsamuel@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2143263002/#ps40001
(title: "removedidswap: fix-webview-swap")

[commit-bot: I haz the power, 2016-07-13 20:04:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:40:26]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-13 21:40:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 21:40:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 21:43:41]

Description was changed from

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove OutputSurfaceClient::DidSwapBuffers().

If we call swap, we know that we swapped, so we don't need a callback
to tell us about that. Instead, just have places that call
Renderer::SwapBuffers() do what they would have in the DidSwapBuffers
callback.

It is the DidSwapBuffersComplete() callback that is used
for throttling/unblocking frame production. This one has no
purpose on OutputSurfaceClient.

R=enne, jbauman
TBR=sky,boliu,sievers
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4600da1be6cc2719af18c4cbdc07101e1ba77127
Cr-Commit-Position: refs/heads/master@{#405300}
==========

[commit-bot: I haz the power, 2016-07-13 21:43:43]

Patchset 3 (id:??) landed as
https://crrev.com/4600da1be6cc2719af18c4cbdc07101e1ba77127
Cr-Commit-Position: refs/heads/master@{#405300}