services/ui/public/cpp/lib/output_surface.cc - Issue 2143263002: cc: Remove OutputSurfaceClient::DidSwapBuffers().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/lib/output_surface.cc

Issue 2143263002: cc: Remove OutputSurfaceClient::DidSwapBuffers(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removedidswap: fix-webview-swap Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/public/cpp/lib/output_surface.cc

diff --git a/services/ui/public/cpp/lib/output_surface.cc b/services/ui/public/cpp/lib/output_surface.cc

index d8ce012ce296c2d193b0aa922c74acc0b2ff6061..2d58a0a9f833190f3e76857d02ba2de8f5f37a58 100644

--- a/services/ui/public/cpp/lib/output_surface.cc

+++ b/services/ui/public/cpp/lib/output_surface.cc

@@ -45,8 +45,6 @@ uint32_t OutputSurface::GetFramebufferCopyTextureFormat() {

}

void OutputSurface::SwapBuffers(cc::CompositorFrame frame) {

- // TODO(fsamuel, rjkroege): We should probably throttle compositor frames.

- client_->DidSwapBuffers();

// OutputSurface owns WindowSurface, and so if OutputSurface is

// destroyed then SubmitCompositorFrame's callback will never get called.

// Thus, base::Unretained is safe here.