Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2143073002: Plugin Power Saver: Improve blocked tiny plugins behavior (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Improve blocked tiny plugins behavior. 1. Makes blocked Tiny plugins work with background tabs and prerendering. 2. Add browser tests for background tab tiny plugins and expanding tiny plugins. 3. Refactors and shortens some PluginPlaceholder code. BUG=608886 Committed: https://crrev.com/c654a3dac8b9d49a63f5779614f8a9b7da7abf6b Cr-Commit-Position: refs/heads/master@{#405350}

Patch Set 1 #

Patch Set 2 : rename a var #

Patch Set 3 : add expanding plugin test #

Patch Set 4 : rename some stuff #

Patch Set 5 : rename a variable again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -190 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 3 5 chunks +60 lines, -29 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 3 4 2 chunks +9 lines, -14 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 3 chunks +2 lines, -14 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 3 chunks +6 lines, -59 lines 0 comments Download
M chrome/renderer/plugins/power_saver_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/power_saver_info.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/resources/plugins/blocked_plugin.html View 1 chunk +3 lines, -0 lines 0 comments Download
D chrome/renderer/resources/plugins/plugin_delay.html View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.h View 1 2 3 4 4 chunks +8 lines, -12 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 2 3 4 7 chunks +42 lines, -33 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
tommycli
bauerb: PTAL, thanks!
4 years, 5 months ago (2016-07-12 19:53:51 UTC) #9
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-13 08:24:54 UTC) #10
tommycli
bauerb: thanks!
4 years, 5 months ago (2016-07-13 15:47:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143073002/80001
4 years, 5 months ago (2016-07-13 15:48:26 UTC) #13
tommycli
thestig: PTAL chrome/renderer/chrome_content_renderer_client.cc thanks!
4 years, 5 months ago (2016-07-13 15:49:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217251)
4 years, 5 months ago (2016-07-13 15:56:23 UTC) #17
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-13 17:49:46 UTC) #18
tommycli
On 2016/07/13 17:49:46, Lei Zhang wrote: > lgtm thanks!
4 years, 5 months ago (2016-07-13 17:50:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143073002/80001
4 years, 5 months ago (2016-07-13 17:51:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143073002/80001
4 years, 5 months ago (2016-07-13 17:58:48 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-13 23:49:06 UTC) #26
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 23:49:16 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:50:35 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c654a3dac8b9d49a63f5779614f8a9b7da7abf6b
Cr-Commit-Position: refs/heads/master@{#405350}

Powered by Google App Engine
This is Rietveld 408576698