Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8381)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 2143073002: Plugin Power Saver: Improve blocked tiny plugins behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename a variable again Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index 78348cf2888d7cfec090849f296d0b4591d316e3..e174f6cb8e9e623317531c1b7eb7dd50dae67163 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -37,16 +37,6 @@ class ChromePluginPlaceholder final
const base::string16& message,
const PowerSaverInfo& power_saver_info);
- // Create a plugin placeholder that delays until sizing is known.
- static ChromePluginPlaceholder* CreateDelayedPlugin(
- content::RenderFrame* render_frame,
- blink::WebLocalFrame* frame,
- const blink::WebPluginParams& params,
- const content::WebPluginInfo& info,
- const std::string& identifier,
- const base::string16& name,
- const PowerSaverInfo& power_saver_info);
-
// Creates a new WebViewPlugin with a MissingPlugin as a delegate.
static ChromePluginPlaceholder* CreateLoadableMissingPlugin(
content::RenderFrame* render_frame,
@@ -69,9 +59,7 @@ class ChromePluginPlaceholder final
// content::LoadablePluginPlaceholder overrides.
blink::WebPlugin* CreatePlugin() override;
- void OnLoadedRectUpdate(
- const gfx::Rect& unobscured_rect,
- content::RenderFrame::PeripheralContentStatus status) override;
+ void OnBlockedTinyContent() override;
// gin::Wrappable (via PluginPlaceholder) method
gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
@@ -120,7 +108,7 @@ class ChromePluginPlaceholder final
int context_menu_request_id_; // Nonzero when request pending.
base::string16 plugin_name_;
- bool ignore_updates_;
+ bool did_send_blocked_content_notification_;
DISALLOW_COPY_AND_ASSIGN(ChromePluginPlaceholder);
};
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698