Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2142953002: [Cronet] Fix deprecation warnings in CronetUrlRequestContextTest.java (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix deprecation warnings in CronetUrlRequestContextTest.java CronetEngine.createRequest has been deprecated. This CL changes the test to use the new Builder API. R=kapishnikov@chromium.org BUG=547970 Committed: https://crrev.com/e28dcbb181e20a759ba4bef24227c2ee12a82628 Cr-Commit-Position: refs/heads/master@{#405229}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
xunjieli
4 years, 5 months ago (2016-07-12 14:41:47 UTC) #2
kapishnikov
lgtm
4 years, 5 months ago (2016-07-13 17:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142953002/20001
4 years, 5 months ago (2016-07-13 17:44:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 19:43:03 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:43:33 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:44:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e28dcbb181e20a759ba4bef24227c2ee12a82628
Cr-Commit-Position: refs/heads/master@{#405229}

Powered by Google App Engine
This is Rietveld 408576698