Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2142953002: [Cronet] Fix deprecation warnings in CronetUrlRequestContextTest.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 60244fa1521978d1bbc6360ce36871ff9adbd7ae..0beee033f8b08a7bf56a37a0f1b0424d1b099e5e 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -154,6 +154,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @SuppressWarnings("deprecation")
public void testConfigUserAgent() throws Exception {
String userAgentName = "User-Agent";
String userAgentValue = "User-Agent-Value";
@@ -180,8 +181,6 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
@OnlyRunNativeCronet
- // TODO(xunjieli): Remove annotation after crbug.com/539519 is fixed.
- @SuppressWarnings("deprecation")
public void testDataReductionProxyEnabled() throws Exception {
mTestFramework = startCronetTestFrameworkAndSkipLibraryInit();
@@ -244,8 +243,10 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
} catch (IllegalStateException e) {
}
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest urlRequest =
- mTestFramework.mCronetEngine.createRequest(mUrl, callback, callback.getExecutor());
+ UrlRequest.Builder builder = new UrlRequest.Builder(
+ mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest urlRequest = builder.build();
+
urlRequest.start();
callback.blockForDone();
assertEquals(0, rttListener.rttObservationCount());
@@ -268,8 +269,9 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
mTestFramework.mCronetEngine.addRttListener(rttListener);
mTestFramework.mCronetEngine.removeRttListener(rttListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest urlRequest =
- mTestFramework.mCronetEngine.createRequest(mUrl, callback, callback.getExecutor());
+ UrlRequest.Builder builder = new UrlRequest.Builder(
+ mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest urlRequest = builder.build();
urlRequest.start();
callback.blockForDone();
networkQualityExecutor.runAllTasks();
@@ -303,8 +305,9 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
mTestFramework.mCronetEngine.addThroughputListener(throughputListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest urlRequest =
- mTestFramework.mCronetEngine.createRequest(mUrl, callback, callback.getExecutor());
+ UrlRequest.Builder builder = new UrlRequest.Builder(
+ mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest urlRequest = builder.build();
urlRequest.start();
callback.blockForDone();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698