bluetooth: Avoid including non-blink mojo bindings in blink code

bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink.

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
Committed: https://crrev.com/4928ab440dfc16789b8ec0d9c52717b78a41abb8
Cr-Commit-Position: refs/heads/master@{#405531}

[ortuno, 2016-07-12 21:30:25]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 21:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-07-12 23:03:35]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:06:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 23:21:23]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:21:24]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-07-13 15:22:47]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 15:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-07-13 15:27:16]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content and
blink. In cases where content/renderer passes a non-blink enum we
cast to an int32 and then cast back to a blink enum in blink. Similarly,
for functions that pass a blink enum we cast to an int32 and cast back
to a non-blink enum in condent.

BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content and
blink. So we include the blink and content bindings from
content/renderer and static cast to the appropriate enum where needed. We put
the enums in a separate mojom so that we can include its generated blink
bindings
without bringing all of wtf/


BUG=610415
==========

[commit-bot: I haz the power, 2016-07-13 15:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:32:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ortuno, 2016-07-13 15:39:06]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 15:39:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:50:30]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ortuno, 2016-07-13 15:57:07]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 15:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 16:08:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-07-13 17:32:56]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content and
blink. So we include the blink and content bindings from
content/renderer and static cast to the appropriate enum where needed. We put
the enums in a separate mojom so that we can include its generated blink
bindings
without bringing all of wtf/


BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

BUG=610415
==========

[ortuno, 2016-07-13 17:35:30]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-07-13 17:35:31]

jyasskin: PTAL. Having blink code that includes non-blink mojo bindings cause
problems when these mojo bindings start to bring hidden dependencies more
specifically: the WebBluetoothDeviceId typemap depends on content/common, when
we use non-blink bindings in blink code we make blink depend on content/common
which violates layering rules.

[ortuno, 2016-07-13 18:10:03]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-07-13 19:19:46]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:21:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:34:59]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2016-07-13 20:34:59]

I'm really sad that we're losing our type information, but lgtm with the
comments.

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:30: // Blink shouldn't use
non-blink mojo bindings so we can't return a non-blink
Maybe "Blink can't use non-blink mojo enums like
blink::mojom::WebBluetoothError, so we pass it as an int32 across the boundary."

I'll also point out that it's confusing that a non-blink enum would be named
"blink::mojom::...".

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:98:
static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity),
Could you
CHECK(IsKnownEnumValue(static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity)))
before using it?

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.h (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.h:57: int32_t quantity,
Could you comment what enum defines the values of this argument?

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.h (right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:9: #include
"third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom-blink.h"
Is this include used anymore?

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:23: using WebType =
int32_t;
Please comment which enum this expects to receive.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp:125:
void onError(int32_t error) override
Please comment which enum this expects to receive.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp:51:
void onError(int32_t error) override
Please comment which enum this expects to receive.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp:120:
mojom::blink::WebBluetoothGATTQueryQuantity m_quantity;
I'd probably 'using' this at the top of the file.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp:70:
void onError(int32_t error) override
Please comment which enum this expects to receive.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h:25: using
WebBluetoothRequestDeviceCallbacks =
WebCallbacks<std::unique_ptr<WebBluetoothDeviceInit>, int32_t>;
Please comment which enum each of these expects to receive.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h:64: int32_t
quantity,
Ditto here.

[commit-bot: I haz the power, 2016-07-13 20:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:35:54]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-07-13 22:29:56]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:31:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-07-13 22:47:29]

Me too :( I was hoping to avoid this until we Onion Soup Web Bluetooth.

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:30: // Blink shouldn't use
non-blink mojo bindings so we can't return a non-blink
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Maybe "Blink can't use non-blink mojo enums like
blink::mojom::WebBluetoothError, so we pass it as an int32 across the boundary."
> 

Done.

> I'll also point out that it's confusing that a non-blink enum would be named
"blink::mojom::...".

Yeah I known :/ We incorrectly added the mojom to blink so we are stuck with the
blink namespace.

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:98:
static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity),
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Could you
CHECK(IsKnownEnumValue(static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity)))
before using it?

I could but I'm not sure what would be the benefit. The browser side checks the
enum anyway.

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.h (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.h:57: int32_t quantity,
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Could you comment what enum defines the values of this argument?

Done. What do you think?

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.h (right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:9: #include
"third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom-blink.h"
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Is this include used anymore?

Ah I guess not in the header. Moved to the .cc

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:23: using WebType =
int32_t;
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Please comment which enum this expects to receive.

Done.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp:125:
void onError(int32_t error) override
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Please comment which enum this expects to receive.

Done.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp:51:
void onError(int32_t error) override
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Please comment which enum this expects to receive.

Done.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp:120:
mojom::blink::WebBluetoothGATTQueryQuantity m_quantity;
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> I'd probably 'using' this at the top of the file.

I've been avoiding doing that since it would make the line between mojo types
and blink types blurry and hides the fact that those types are to be used when
communicating with the browser. Also there are no instances of "using"
mojom::blink.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp:70:
void onError(int32_t error) override
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Please comment which enum this expects to receive.

Done.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h:25: using
WebBluetoothRequestDeviceCallbacks =
WebCallbacks<std::unique_ptr<WebBluetoothDeviceInit>, int32_t>;
On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> Please comment which enum each of these expects to receive.

Done.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h:64: int32_t
quantity,
On 2016/07/13 at 20:34:59, Jeffrey Yasskin wrote:
> Ditto here.

Done.

[Jeffrey Yasskin, 2016-07-13 22:56:14]

LGTM

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:98:
static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity),
On 2016/07/13 22:47:28, ortuno wrote:
> On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> > Could you
>
CHECK(IsKnownEnumValue(static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity)))
> before using it?
> 
> I could but I'm not sure what would be the benefit. The browser side checks
the
> enum anyway.

It makes sure that we match enums across the boundary, since the type system
isn't doing it for us. A DCHECK is probably just as fine since these are scoped
enums with an underlying type.

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
(right):

https://codereview.chromium.org/2142813003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp:120:
mojom::blink::WebBluetoothGATTQueryQuantity m_quantity;
On 2016/07/13 22:47:29, ortuno wrote:
> On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> > I'd probably 'using' this at the top of the file.
> 
> I've been avoiding doing that since it would make the line between mojo types
> and blink types blurry and hides the fact that those types are to be used when
> communicating with the browser. Also there are no instances of "using"
> mojom::blink.

Ok.

[ortuno, 2016-07-13 23:12:40]

Thanks!

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2142813003/diff/120001/content/renderer/bluet...
content/renderer/bluetooth/web_bluetooth_impl.cc:98:
static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity),
On 2016/07/13 at 22:56:14, Jeffrey Yasskin wrote:
> On 2016/07/13 22:47:28, ortuno wrote:
> > On 2016/07/13 at 20:34:58, Jeffrey Yasskin wrote:
> > > Could you
> >
CHECK(IsKnownEnumValue(static_cast<blink::mojom::WebBluetoothGATTQueryQuantity>(quantity)))
> > before using it?
> > 
> > I could but I'm not sure what would be the benefit. The browser side checks
the
> > enum anyway.
> 
> It makes sure that we match enums across the boundary, since the type system
isn't doing it for us. A DCHECK is probably just as fine since these are scoped
enums with an underlying type.

Done.

[ortuno, 2016-07-13 23:24:22]

ortuno@chromium.org changed reviewers:
+ avi@chromium.org, bajones@chromium.org, haraken@chromium.org,
jbroman@chromium.org, wolenetz@chromium.org

[ortuno, 2016-07-13 23:24:23]

haraken: third_party/WebKit/Source/modules/BUILD.gn
jbroman: t/WebKit/public/BUILD.gn & blink_headers.gypi
avi: content/common/DEPS
bajones: device/vr/BUILD.gn
wolenetz: media/blink/BUILD.gn

[ortuno, 2016-07-13 23:24:29]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[ortuno, 2016-07-13 23:25:21]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

[commit-bot: I haz the power, 2016-07-13 23:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-07-13 23:42:05]

souping lgtm

[bajones, 2016-07-14 00:44:24]

Device/VR LGTM

[haraken, 2016-07-14 00:58:53]

modules/ LGTM

[commit-bot: I haz the power, 2016-07-14 01:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:25:27]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-07-14 15:09:51]

okay, lgtm

[wolenetz, 2016-07-14 17:45:59]

wolenetz@chromium.org changed reviewers:
+ sandersd@chromium.org

[wolenetz, 2016-07-14 17:46:00]

redirecting the media/blink mojo binding change review to sandersd@

[wolenetz, 2016-07-14 17:51:58]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

[wolenetz, 2016-07-14 17:51:58]

wolenetz@chromium.org changed reviewers:
- wolenetz@chromium.org

[sandersd (OOO until July 31), 2016-07-14 17:52:14]

On 2016/07/14 17:46:00, wolenetz wrote:
> redirecting the media/blink mojo binding change review to sandersd@

media/ lgtm

[ortuno, 2016-07-14 17:56:38]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-07-14 17:56:39]

Thanks all!

[ortuno, 2016-07-14 17:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2142813003/#ps180001
(title: "Add DCHECK for enum")

[commit-bot: I haz the power, 2016-07-14 17:57:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:07:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2016-07-14 18:19:59]

ortuno@chromium.org changed reviewers:
+ esprehn@chromium.org

[ortuno, 2016-07-14 18:20:00]

esprehn: owner's review for third_party/WebKit/public/BUILD.gn and blink_headers
please.

[esprehn, 2016-07-14 18:26:29]

lgtm

[ortuno, 2016-07-14 19:05:09]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:05:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:11:31]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

[commit-bot: I haz the power, 2016-07-14 19:11:33]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-14 19:12:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 19:12:51]

Description was changed from

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink. 

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415
==========

to

==========
bluetooth: Avoid including non-blink mojo bindings in blink code

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink.

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415

Committed: https://crrev.com/4928ab440dfc16789b8ec0d9c52717b78a41abb8
Cr-Commit-Position: refs/heads/master@{#405531}
==========

[commit-bot: I haz the power, 2016-07-14 19:12:52]

Patchset 10 (id:??) landed as
https://crrev.com/4928ab440dfc16789b8ec0d9c52717b78a41abb8
Cr-Commit-Position: refs/heads/master@{#405531}