third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp - Issue 2142813003: bluetooth: Avoid including non-blink mojo bindings in blink code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2142813003: bluetooth: Avoid including non-blink mojo bindings in blink code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Add DCHECK for enum Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

index 98d0d933fa8f9cf87acc76ba1f196f075e685c14..b0ec4cd4b83d32eaf271d801427356099afb4460 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

@@ -122,11 +122,11 @@ public:

m_resolver->resolve(domDataView);

}

- void onError(const WebBluetoothError& e) override

+ void onError(int32_t error /* Corresponds to WebBluetoothError in web_bluetooth.mojom */) override

{

if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

- m_resolver->reject(BluetoothError::take(m_resolver, e));

+ m_resolver->reject(BluetoothError::take(m_resolver, error));

}

private:

@@ -160,11 +160,11 @@ public:

m_resolver->resolve();

}