Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2142723002: Added idlharness-based test for Web Share API. (Closed)

Created:
4 years, 5 months ago by Matt Giuca
Modified:
3 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, blink-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webshare-requester-mojo-blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added idlharness-based test for Web Share API. BUG=627310 Review-Url: https://codereview.chromium.org/2142723002 Cr-Commit-Position: refs/heads/master@{#442531} Committed: https://chromium.googlesource.com/chromium/src/+/75e45a73e34b7a32e3f0eca14c11f0f54582c761

Patch Set 1 #

Patch Set 2 : Remove TODO: crbug.com/627309 is fixed now. #

Patch Set 3 : Update IDL to match current share API. Test passes. #

Patch Set 4 : Remove trailing line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/webshare/idl.html View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Matt Giuca
If you recall, this was blocked on https://crbug.com/627309 which is now fixed. There isn't much ...
3 years, 11 months ago (2017-01-10 06:33:27 UTC) #2
Sam McNally
lgtm
3 years, 11 months ago (2017-01-10 06:40:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142723002/60001
3 years, 11 months ago (2017-01-10 06:47:04 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 08:06:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/75e45a73e34b7a32e3f0eca14c11...

Powered by Google App Engine
This is Rietveld 408576698