components/offline_pages/offline_page_model_impl.h - Issue 2142703002: [Offline Pages] Showing expired pages in internal page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2142703002: [Offline Pages] Showing expired pages in internal page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/offline_pages/offline_internals.js ('K') | « components/offline_pages/offline_page_model.h ('k') | components/offline_pages/offline_page_model_impl.cc » ('j') | components/offline_pages/offline_page_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.h

diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h

index 1efb687e3ad325976d84351883ad18f7423d30e0..14ef621b61ca53ca65810f40d5c5553224e5dbeb 100644

--- a/components/offline_pages/offline_page_model_impl.h

+++ b/components/offline_pages/offline_page_model_impl.h

@@ -81,6 +81,8 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

const std::set<GURL>& urls,

const CheckPagesExistOfflineCallback& callback) override;

void GetAllPages(const MultipleOfflinePageItemCallback& callback) override;

+ void GetAllPagesWithExpired(

+ const MultipleOfflinePageItemCallback& callback) override;

void GetOfflineIdsForClientId(

const ClientId& client_id,

const MultipleOfflineIdCallback& callback) override;

@@ -133,6 +135,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

void OnEnsureArchivesDirCreatedDone(const base::TimeTicks& start_time);

void GetAllPagesAfterLoadDone(

+ bool with_expired,

const MultipleOfflinePageItemCallback& callback) const;

void CheckPagesExistOfflineAfterLoadDone(

const std::set<GURL>& urls,