[Offline Pages] Showing expired pages in internal page.

chrome/browser/resources/offline_pages/offline_internals.js

Index: chrome/browser/resources/offline_pages/offline_internals.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals.js b/chrome/browser/resources/offline_pages/offline_internals.js
index b4690eec480ec2c6b14105163637b3fbd77d123f..dc1ed19269cf37a1084985e444c8cb3ad6df133a 100644
--- a/chrome/browser/resources/offline_pages/offline_internals.js
+++ b/chrome/browser/resources/offline_pages/offline_internals.js
@@ -48,6 +48,10 @@ cr.define('offlineInternals', function() {
       cell.textContent = Math.round(pages[i].size / 1024);
       row.appendChild(cell);
 
+      cell = document.createElement('td');
+      cell.textContent = pages[i].expired;

[michaelpg, 2016/07/13 00:09:21]

This will implicitly set textContent to 'true' or 'false' if I understand this
CL correctly. Please use an explicit string:
    pages[i].expired.toString()
or 'Yes'/'No' or whatever.

(Is that really what you want? Or would something like a "Status" column with a
possible "Expired" value make more sense?)

[romax, 2016/07/13 20:01:08]

I'll change it to Yes/No and I think it's enough. A 'status' column would have
some empty cells for the not-expired pages.

+      row.appendChild(cell);
+
       storedPagesTable.appendChild(row);
     }
     offlinePages = pages;