Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 214263002: [refactor] Split wrap-unwrap.html into smaller files, and directly check the error result. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[refactor] Split wrap-unwrap.html into smaller files, and directly check the error result. wrap-unwrap.html becomes these files: * wrapKey-unextractable.html * wrapKey-lacks-usage.html * wrapKey-badParameters.html * unwrapKey-lacks-usage.html * unwrapKey-badParameters.html BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170201

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -291 lines) Patch
A + LayoutTests/crypto/unwrapKey-badParameters.html View 2 chunks +26 lines, -56 lines 0 comments Download
A + LayoutTests/crypto/unwrapKey-badParameters-expected.txt View 1 chunk +4 lines, -19 lines 0 comments Download
A + LayoutTests/crypto/unwrapKey-lacks-usage.html View 1 chunk +16 lines, -14 lines 0 comments Download
A + LayoutTests/crypto/unwrapKey-lacks-usage-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
D LayoutTests/crypto/wrap-unwrap.html View 1 chunk +0 lines, -101 lines 0 comments Download
D LayoutTests/crypto/wrap-unwrap-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-badParameters.html View 1 chunk +36 lines, -25 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-badParameters-expected.txt View 1 chunk +5 lines, -9 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-lacks-usage.html View 1 chunk +22 lines, -12 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-lacks-usage-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-unextractable.html View 1 chunk +23 lines, -11 lines 0 comments Download
A + LayoutTests/crypto/wrapKey-unextractable-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Almost done with these pedantic refactors, just generateKey left now! (These are precursors to changing ...
6 years, 9 months ago (2014-03-27 05:09:27 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-27 20:05:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/214263002/20001
6 years, 9 months ago (2014-03-27 20:05:25 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 20:13:56 UTC) #4
Message was sent while issue was closed.
Change committed as 170201

Powered by Google App Engine
This is Rietveld 408576698