Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2142303002: Revert of DevTools: automatically populate 'More tools' submenu with the drawer views. (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: automatically populate 'More tools' submenu with the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) Reason for revert: Possible compile failure on Linux ChromiumOS GN Original issue's description: > DevTools: automatically populate 'More tools' submenu with the drawer views. > > NOTRY=true > NOPRESUBMIT=true > > Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37 > Cr-Commit-Position: refs/heads/master@{#404838} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/07d2063bc853aebc485346bbe118f33d8b54d597 Committed: https://crrev.com/df46eddf339c3c4651c033ed0ad5f3fb459beb3a Cr-Original-Commit-Position: refs/heads/master@{#404845} Cr-Commit-Position: refs/heads/master@{#404848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -85 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 4 chunks +6 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/module.json View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/devicesView.css View 4 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/module.json View 1 chunk +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ActionRegistry.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 4 chunks +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
nektarios
Created Revert of DevTools: automatically populate 'More tools' submenu with the drawer views.
4 years, 5 months ago (2016-07-12 22:20:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142303002/1
4 years, 5 months ago (2016-07-12 22:23:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:26:26 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 22:26:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/07d2063bc853aebc485346bbe118f33d8b54d597 Cr-Commit-Position: refs/heads/master@{#404845}
4 years, 5 months ago (2016-07-12 22:29:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142303002/1
4 years, 5 months ago (2016-07-12 22:37:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:39:42 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 22:40:41 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df46eddf339c3c4651c033ed0ad5f3fb459beb3a Cr-Commit-Position: refs/heads/master@{#404848}
4 years, 5 months ago (2016-07-12 22:41:05 UTC) #13
nektarios
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2141273002/ by nektar@chromium.org. ...
4 years, 5 months ago (2016-07-12 22:55:27 UTC) #14
nektarios
4 years, 5 months ago (2016-07-12 22:55:31 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2145763002/ by nektar@chromium.org.

The reason for reverting is: Was not the one responsible for the bot failures..

Powered by Google App Engine
This is Rietveld 408576698