DevTools: automatically populate 'More tools' submenu with the drawer views.

DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37
Committed: https://crrev.com/70750d574c11fc0e6110d25c46c9a35bfc838338
Cr-Original-Commit-Position: refs/heads/master@{#404838}
Cr-Commit-Position: refs/heads/master@{#404849}

[pfeldman, 2016-07-09 01:01:46]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-07-09 01:12:16]

lgtm

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/Runtime.js:605: var title1 =
extension1.descriptor()["title"] || "";
We have title(platform) function. Let's pass platform to extensions() as well?

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/module.json (left):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/module.json:5:
"className": "WebInspector.AnimationTimeline.ButtonProvider",
What happened to this?

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/devices/module.json (right):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/devices/module.json:9: "className":
"WebInspector.DevicesView"
Let's add tags: usb, android, mobile

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (left):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:1278: for (var i =
0; i < extensions.length; i++) {
This code made it so all permanent tabs are always first. Please revert.

[pfeldman, 2016-07-09 01:37:04]

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/Runtime.js:605: var title1 =
extension1.descriptor()["title"] || "";
On 2016/07/09 01:12:15, dgozman wrote:
> We have title(platform) function. Let's pass platform to extensions() as well?

I actually don't like it even in title. Seems like we should be configuring
runtime with the platform rather at start instead of passing it into every call.

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/module.json (left):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/module.json:5:
"className": "WebInspector.AnimationTimeline.ButtonProvider",
On 2016/07/09 01:12:15, dgozman wrote:
> What happened to this?

Got removed!

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/devices/module.json (right):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/devices/module.json:9: "className":
"WebInspector.DevicesView"
On 2016/07/09 01:12:15, dgozman wrote:
> Let's add tags: usb, android, mobile

Done.

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (left):

https://codereview.chromium.org/2137763002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:1278: for (var i =
0; i < extensions.length; i++) {
On 2016/07/09 01:12:15, dgozman wrote:
> This code made it so all permanent tabs are always first. Please revert.

We are controlling this using extension order.

[dgozman, 2016-07-09 01:39:22]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-09 01:39:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2137763002/#ps20001
(title: "lcean")

[commit-bot: I haz the power, 2016-07-09 01:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-09 01:40:00]

The CQ bit was unchecked by dgozman@chromium.org

[pfeldman, 2016-07-09 01:45:26]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-07-09 01:45:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2137763002/#ps40001
(title: "lcean")

[commit-bot: I haz the power, 2016-07-09 01:45:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 01:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 01:58:05]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pfeldman, 2016-07-11 21:32:49]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-07-11 21:32:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2137763002/#ps60001
(title: "for landing")

[commit-bot: I haz the power, 2016-07-11 21:33:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 23:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:35:47]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-07-12 00:24:46]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:25:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 04:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:33:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-07-12 20:46:21]

Description was changed from

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.
==========

to

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
==========

[pfeldman, 2016-07-12 20:46:25]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:49:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-07-12 21:41:11]

Description was changed from

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
==========

to

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true
==========

[pfeldman, 2016-07-12 21:41:17]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-07-12 21:41:23]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:44:37]

Description was changed from

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true
==========

to

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-07-12 21:44:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-12 21:45:38]

Description was changed from

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true
==========

to

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37
Cr-Commit-Position: refs/heads/master@{#404838}
==========

[commit-bot: I haz the power, 2016-07-12 21:45:40]

Patchset 4 (id:??) landed as
https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37
Cr-Commit-Position: refs/heads/master@{#404838}

[commit-bot: I haz the power, 2016-07-12 21:45:54]

CQ bit was unchecked.

[nektarios, 2016-07-12 22:20:40]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2142303002/ by nektar@chromium.org.

The reason for reverting is: Possible compile failure on Linux ChromiumOS GN .

[nektarios, 2016-07-12 22:36:44]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:41:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-12 22:42:44]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-12 22:43:12]

Description was changed from

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37
Cr-Commit-Position: refs/heads/master@{#404838}
==========

to

==========
DevTools: automatically populate 'More tools' submenu with the drawer views.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37
Committed: https://crrev.com/70750d574c11fc0e6110d25c46c9a35bfc838338
Cr-Original-Commit-Position: refs/heads/master@{#404838}
Cr-Commit-Position: refs/heads/master@{#404849}
==========

[commit-bot: I haz the power, 2016-07-12 22:43:14]

Patchset 4 (id:??) landed as
https://crrev.com/70750d574c11fc0e6110d25c46c9a35bfc838338
Cr-Commit-Position: refs/heads/master@{#404849}