 Chromium Code Reviews
 Chromium Code Reviews Issue 2142273003:
  [interpreter] Inline Star on dispatch for some bytecodes  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 2142273003:
  [interpreter] Inline Star on dispatch for some bytecodes  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/interpreter/interpreter-assembler.h | 
| diff --git a/src/interpreter/interpreter-assembler.h b/src/interpreter/interpreter-assembler.h | 
| index 183d4ddaefff1e11306170eea5be41dee460e64a..d437a70865c9775615f75b3b6216f8115781015f 100644 | 
| --- a/src/interpreter/interpreter-assembler.h | 
| +++ b/src/interpreter/interpreter-assembler.h | 
| @@ -218,14 +218,34 @@ class InterpreterAssembler : public CodeStubAssembler { | 
| // JumpIfWordNotEqual. | 
| void JumpConditional(compiler::Node* condition, compiler::Node* jump_offset); | 
| - // Returns BytecodeOffset() advanced by delta bytecodes. Note: this does not | 
| - // update BytecodeOffset() itself. | 
| + // Updates and returns BytecodeOffset() advanced by the current bytecode's | 
| + // size. Traces the exit of the current bytecode. | 
| + compiler::Node* Advance(); | 
| + | 
| + // Updates and returns BytecodeOffset() advanced by delta bytecodes. | 
| + // Traces the exit of the current bytecode. | 
| compiler::Node* Advance(int delta); | 
| compiler::Node* Advance(compiler::Node* delta); | 
| + // Load the bytecode at |bytecode_offset|. | 
| + compiler::Node* LoadBytecode(compiler::Node* bytecode_offset); | 
| + | 
| + // Look ahead for Star and inline it, will bind the next bytecode to dispatch | 
| + // to, to |target_bytecode| and its offset to |target_offset|. | 
| + void StarDispatchLookahead(Variable& target_bytecode); | 
| + | 
| + // Build code for Star at |target_offset| and bind |target_offset| to the | 
| + // next offset after Star | 
| + void InlineStar(); | 
| + | 
| // Starts next instruction dispatch at |new_bytecode_offset|. | 
| compiler::Node* DispatchTo(compiler::Node* new_bytecode_offset); | 
| + // Dispatch to |target_bytecode| at |new_bytecode_offset|. | 
| + // |target_bytecode| should be equivalent to loading from the offset. | 
| + compiler::Node* DispatchToBytecode(compiler::Node* target_bytecode, | 
| + compiler::Node* new_bytecode_offset); | 
| + | 
| // Dispatch to the bytecode handler with code offset |handler|. | 
| compiler::Node* DispatchToBytecodeHandler(compiler::Node* handler, | 
| compiler::Node* bytecode_offset); | 
| @@ -237,6 +257,7 @@ class InterpreterAssembler : public CodeStubAssembler { | 
| OperandScale operand_scale() const { return operand_scale_; } | 
| Bytecode bytecode_; | 
| + CodeStubAssembler::Variable bytecode_offset_; | 
| 
rmcilroy
2016/07/19 20:18:27
nit - move one down with other variables.
 
klaasb
2016/07/20 09:26:24
Done.
 | 
| OperandScale operand_scale_; | 
| CodeStubAssembler::Variable interpreted_frame_pointer_; | 
| CodeStubAssembler::Variable accumulator_; |