src/interpreter/interpreter.cc - Issue 2142273003: [interpreter] Inline Star on dispatch for some bytecodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/interpreter.cc

Issue 2142273003: [interpreter] Inline Star on dispatch for some bytecodes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: move kInterpreterTraceBytecodeExit to the right place Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/interpreter.cc

diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc

index 1d12bfbc17c838bf50af90056852489f2aa7e3e0..ccd7e86ffecf411714a3c6a8bb419ade4975a85c 100644

--- a/src/interpreter/interpreter.cc

+++ b/src/interpreter/interpreter.cc

@@ -1651,6 +1651,7 @@ void Interpreter::DoCreateObjectLiteral(InterpreterAssembler* assembler) {

__ CallRuntime(Runtime::kCreateObjectLiteral, context, closure,

literal_index, constant_elements, flags);

__ SetAccumulator(result);

+ // TODO(klaasb) build a single dispatch once the call is inlined

__ Dispatch();

}