Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2142253002: [Remoting Android] Fix GetWeakPtr() calls on multiple threads (Closed)

Created:
4 years, 5 months ago by Yuwei
Modified:
4 years, 5 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Fix GetWeakPtr() calls on multiple threads According to recent discovery of the thread safety issue of WeakPtrFactory, WeakptrFactory::GetWeakPtr() can't be called on multiple threads. This CL makes Android JNI classes that expose GetWeakPtr() function to store the WeakPtr in constructor and simply return the stored WeakPtr in GetWeakPtr(). BUG=627602 Committed: https://crrev.com/bdbc56ba8839e6bb32a3677bf199234641f36806 Cr-Commit-Position: refs/heads/master@{#404948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M remoting/client/jni/chromoting_jni_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/client/jni/jni_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/jni/jni_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/client/jni/jni_display_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/jni/jni_display_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M remoting/client/jni/jni_pairing_secret_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/jni/jni_pairing_secret_fetcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuwei
ptal
4 years, 5 months ago (2016-07-12 22:05:39 UTC) #2
Lambros
lgtm
4 years, 5 months ago (2016-07-12 22:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142253002/1
4 years, 5 months ago (2016-07-13 00:53:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:18:20 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:19:35 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:21:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdbc56ba8839e6bb32a3677bf199234641f36806
Cr-Commit-Position: refs/heads/master@{#404948}

Powered by Google App Engine
This is Rietveld 408576698